From 334061459553143e7d3feade0cd0227b363489b9 Mon Sep 17 00:00:00 2001
From: Paul Schaub <vanitasvitae@fsfe.org>
Date: Thu, 8 May 2025 12:54:25 +0200
Subject: [PATCH] Remove unused SignatureComparator classes

---
 .../SignatureCreationDateComparator.kt        | 30 -----------------
 .../consumer/SignatureValidityComparator.kt   | 32 -------------------
 2 files changed, 62 deletions(-)
 delete mode 100644 pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureCreationDateComparator.kt
 delete mode 100644 pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureValidityComparator.kt

diff --git a/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureCreationDateComparator.kt b/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureCreationDateComparator.kt
deleted file mode 100644
index a913bf32..00000000
--- a/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureCreationDateComparator.kt
+++ /dev/null
@@ -1,30 +0,0 @@
-// SPDX-FileCopyrightText: 2023 Paul Schaub <vanitasvitae@fsfe.org>
-//
-// SPDX-License-Identifier: Apache-2.0
-
-package org.pgpainless.signature.consumer
-
-import org.bouncycastle.openpgp.PGPSignature
-
-/**
- * Create a new comparator which sorts signatures according to the passed ordering.
- *
- * @param order ordering
- */
-class SignatureCreationDateComparator(private val order: Order = Order.OLD_TO_NEW) :
-    Comparator<PGPSignature> {
-
-    enum class Order {
-        /** Oldest signatures first. */
-        OLD_TO_NEW,
-        /** Newest signatures first. */
-        NEW_TO_OLD
-    }
-
-    override fun compare(one: PGPSignature, two: PGPSignature): Int {
-        return when (order) {
-            Order.OLD_TO_NEW -> one.creationTime.compareTo(two.creationTime)
-            Order.NEW_TO_OLD -> two.creationTime.compareTo(one.creationTime)
-        }
-    }
-}
diff --git a/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureValidityComparator.kt b/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureValidityComparator.kt
deleted file mode 100644
index 1153b875..00000000
--- a/pgpainless-core/src/main/kotlin/org/pgpainless/signature/consumer/SignatureValidityComparator.kt
+++ /dev/null
@@ -1,32 +0,0 @@
-// SPDX-FileCopyrightText: 2023 Paul Schaub <vanitasvitae@fsfe.org>
-//
-// SPDX-License-Identifier: Apache-2.0
-
-package org.pgpainless.signature.consumer
-
-import org.bouncycastle.openpgp.PGPSignature
-import org.pgpainless.bouncycastle.extensions.isHardRevocation
-
-/**
- * Comparator which sorts signatures based on an ordering and on revocation hardness.
- *
- * If a list of signatures gets ordered using this comparator, hard revocations will always come
- * first. Further, signatures are ordered by date according to the
- * [SignatureCreationDateComparator.Order].
- */
-class SignatureValidityComparator(
-    order: SignatureCreationDateComparator.Order = SignatureCreationDateComparator.Order.OLD_TO_NEW
-) : Comparator<PGPSignature> {
-
-    private val creationDateComparator: SignatureCreationDateComparator =
-        SignatureCreationDateComparator(order)
-
-    override fun compare(one: PGPSignature, two: PGPSignature): Int {
-        return if (one.isHardRevocation == two.isHardRevocation) {
-            // Both have the same hardness, so compare creation time
-            creationDateComparator.compare(one, two)
-        }
-        // else favor the "harder" signature
-        else if (one.isHardRevocation) -1 else 1
-    }
-}