From 74609e0ef7e9b4a97083d9bb1c0b0fea46db8d25 Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Fri, 12 Nov 2021 16:52:32 +0100 Subject: [PATCH] Add another test for deletion of non-existent user-ids from key --- .../org/pgpainless/key/util/KeyRingUtilTest.java | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/pgpainless-core/src/test/java/org/pgpainless/key/util/KeyRingUtilTest.java b/pgpainless-core/src/test/java/org/pgpainless/key/util/KeyRingUtilTest.java index d939dc24..d1384e40 100644 --- a/pgpainless-core/src/test/java/org/pgpainless/key/util/KeyRingUtilTest.java +++ b/pgpainless-core/src/test/java/org/pgpainless/key/util/KeyRingUtilTest.java @@ -5,9 +5,11 @@ package org.pgpainless.key.util; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.security.InvalidAlgorithmParameterException; import java.security.NoSuchAlgorithmException; +import java.util.NoSuchElementException; import org.bouncycastle.openpgp.PGPException; import org.bouncycastle.openpgp.PGPPublicKeyRing; @@ -36,7 +38,8 @@ public class KeyRingUtilTest { } @Test - public void testDeleteUserIdFromPublicKeyRing() throws PGPException, InvalidAlgorithmParameterException, NoSuchAlgorithmException { + public void testDeleteUserIdFromPublicKeyRing() + throws PGPException, InvalidAlgorithmParameterException, NoSuchAlgorithmException { PGPSecretKeyRing secretKeys = PGPainless.generateKeyRing() .modernKeyRing("Alice", null); @@ -50,4 +53,14 @@ public class KeyRingUtilTest { assertEquals(1, CollectionUtils.iteratorToList(publicKeys.getPublicKey().getUserIDs()).size()); } + + @Test + public void testDeleteNonexistentUserIdFromKeyRingThrows() + throws PGPException, InvalidAlgorithmParameterException, NoSuchAlgorithmException { + PGPSecretKeyRing secretKeys = PGPainless.generateKeyRing() + .modernKeyRing("Alice", null); + + assertThrows(NoSuchElementException.class, + () -> KeyRingUtils.deleteUserIdFromSecretKeyRing(secretKeys, "Charlie")); + } }