Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2025-12-06 13:11:08 +01:00
Code Issues Releases Wiki Activity

Make Objects.requireNonNull() throw IllegalArgumentException

Browse source 
and not NullPointerException. Altough this differs from
java.util.Objects behavior, throwing an IllegalArgumentException
appears more sensible and makes it easier to catch it in Smack's
parsing function.
This commit is contained in:
Florian Schmaus 2019-06-11 12:32:42 +02:00
parent 9bb36fc63c
commit 818ee8a727
5 changed files with 33 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
smack-core/src/test/java/org/jivesoftware/smack/packet/PresenceTest.java
View file

@ -20,10 +20,11 @@ import static org.jivesoftware.smack.test.util.XmlUnitUtils.assertXmlSimilar;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertThrows;
import java.io.IOException;
import org.junit.Test;
import org.junit.jupiter.api.Test;
import org.xml.sax.SAXException;
public class PresenceTest {
@ -59,9 +60,11 @@ public class PresenceTest {
assertXmlSimilar(control, presenceTypeSet.toXML(StreamOpen.CLIENT_NAMESPACE).toString());
}
@Test(expected = NullPointerException.class)
@Test
public void setNullPresenceTypeTest() {
getNewPresence().setType(null);
assertThrows(IllegalArgumentException.class, () ->
getNewPresence().setType(null)
);
}
@Test
@ -112,9 +115,11 @@ public class PresenceTest {
assertXmlSimilar(control, presence.toXML(StreamOpen.CLIENT_NAMESPACE).toString());
}
@Test(expected = IllegalArgumentException.class)
@Test
public void setIllegalPriorityTest() {
getNewPresence().setPriority(Integer.MIN_VALUE);
assertThrows(IllegalArgumentException.class, () ->
getNewPresence().setPriority(Integer.MIN_VALUE)
);
}
@Test