1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2025-09-10 02:39:42 +02:00

Enable RedundantModifier checkstyle check

This commit is contained in:
Florian Schmaus 2018-03-28 14:02:21 +02:00
parent 193688e553
commit b5209f4701
36 changed files with 86 additions and 85 deletions

View file

@ -293,7 +293,7 @@ public class MultipleRecipientManager {
* (i.e. cannot change the TO address of a queues stanza(/packet) to be sent) then this class was
* created to keep the XML stanza to send.
*/
private static class PacketCopy extends Stanza {
private static final class PacketCopy extends Stanza {
private final CharSequence text;
@ -303,7 +303,7 @@ public class MultipleRecipientManager {
*
* @param text the whole text of the stanza(/packet) to send
*/
public PacketCopy(CharSequence text) {
private PacketCopy(CharSequence text) {
this.text = text;
}

View file

@ -48,7 +48,7 @@ class DataListener extends AbstractIqRequestHandler {
*
* @param manager the In-Band Bytestream manager
*/
public DataListener(InBandBytestreamManager manager) {
DataListener(InBandBytestreamManager manager) {
super(DataPacketExtension.ELEMENT, DataPacketExtension.NAMESPACE, IQ.Type.set, Mode.async);
this.manager = manager;
}

View file

@ -274,7 +274,7 @@ public class InBandBytestreamSession implements BytestreamSession {
/**
* Constructor.
*/
public IBBInputStream() {
protected IBBInputStream() {
// add data packet listener to connection
this.dataPacketListener = getDataPacketListener();
connection.addSyncStanzaListener(this.dataPacketListener, getDataPacketFilter());
@ -627,7 +627,7 @@ public class InBandBytestreamSession implements BytestreamSession {
/**
* Constructor.
*/
public IBBOutputStream() {
private IBBOutputStream() {
this.buffer = new byte[byteStreamRequest.getBlockSize()];
}

View file

@ -664,14 +664,14 @@ public final class AdHocCommandManager extends Manager {
/**
* Stores ad-hoc command information.
*/
private static class AdHocCommandInfo {
private static final class AdHocCommandInfo {
private String node;
private String name;
private final Jid ownerJID;
private LocalCommandFactory factory;
public AdHocCommandInfo(String node, String name, Jid ownerJID,
private AdHocCommandInfo(String node, String name, Jid ownerJID,
LocalCommandFactory factory)
{
this.node = node;

View file

@ -29,5 +29,5 @@ public interface FileTransferListener {
* @param request
* The request from the other user.
*/
void fileTransferRequest(final FileTransferRequest request);
void fileTransferRequest(FileTransferRequest request);
}

View file

@ -345,12 +345,12 @@ public class JingleS5BTransportSession extends JingleTransportSession<JingleS5BT
return JingleS5BTransportManager.getInstanceFor(jingleSession.getConnection());
}
private static class UsedCandidate {
private static final class UsedCandidate {
private final Socket socket;
private final JingleS5BTransport transport;
private final JingleS5BTransportCandidate candidate;
public UsedCandidate(JingleS5BTransport transport, JingleS5BTransportCandidate candidate, Socket socket) {
private UsedCandidate(JingleS5BTransport transport, JingleS5BTransportCandidate candidate, Socket socket) {
this.socket = socket;
this.transport = transport;
this.candidate = candidate;

View file

@ -45,7 +45,7 @@ public interface InvitationListener {
* @param message the message used by the inviter to send the invitation.
* @param invitation the raw invitation received with the message.
*/
public abstract void invitationReceived(XMPPConnection conn, MultiUserChat room, EntityJid inviter, String reason,
void invitationReceived(XMPPConnection conn, MultiUserChat room, EntityJid inviter, String reason,
String password, Message message, MUCUser.Invite invitation);
}

View file

@ -38,6 +38,6 @@ public interface InvitationRejectionListener {
* @param message the message used to decline the invitation.
* @param rejection the raw decline found in the message.
*/
public abstract void invitationDeclined(EntityBareJid invitee, String reason, Message message, MUCUser.Decline rejection);
void invitationDeclined(EntityBareJid invitee, String reason, Message message, MUCUser.Decline rejection);
}

View file

@ -37,7 +37,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that has just joined the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void joined(EntityFullJid participant);
void joined(EntityFullJid participant);
/**
* Called when a room occupant has left the room on its own. This means that the occupant was
@ -46,7 +46,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that has left the room on its own.
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void left(EntityFullJid participant);
void left(EntityFullJid participant);
/**
* Called when a room participant has been kicked from the room. This means that the kicked
@ -57,7 +57,7 @@ public interface ParticipantStatusListener {
* @param actor the moderator that kicked the occupant from the room (e.g. user@host.org).
* @param reason the reason provided by the actor to kick the occupant from the room.
*/
public abstract void kicked(EntityFullJid participant, Jid actor, String reason);
void kicked(EntityFullJid participant, Jid actor, String reason);
/**
* Called when a moderator grants voice to a visitor. This means that the visitor
@ -66,7 +66,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was granted voice in the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void voiceGranted(EntityFullJid participant);
void voiceGranted(EntityFullJid participant);
/**
* Called when a moderator revokes voice from a participant. This means that the participant
@ -76,7 +76,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was revoked voice from the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void voiceRevoked(EntityFullJid participant);
void voiceRevoked(EntityFullJid participant);
/**
* Called when an administrator or owner banned a participant from the room. This means that
@ -87,7 +87,7 @@ public interface ParticipantStatusListener {
* @param actor the administrator that banned the occupant (e.g. user@host.org).
* @param reason the reason provided by the administrator to ban the occupant.
*/
public abstract void banned(EntityFullJid participant, Jid actor, String reason);
void banned(EntityFullJid participant, Jid actor, String reason);
/**
* Called when an administrator grants a user membership to the room. This means that the user
@ -96,7 +96,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was granted membership in the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void membershipGranted(EntityFullJid participant);
void membershipGranted(EntityFullJid participant);
/**
* Called when an administrator revokes a user membership to the room. This means that the
@ -105,7 +105,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was revoked membership from the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void membershipRevoked(EntityFullJid participant);
void membershipRevoked(EntityFullJid participant);
/**
* Called when an administrator grants moderator privileges to a user. This means that the user
@ -115,7 +115,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was granted moderator privileges in the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void moderatorGranted(EntityFullJid participant);
void moderatorGranted(EntityFullJid participant);
/**
* Called when an administrator revokes moderator privileges from a user. This means that the
@ -125,7 +125,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was revoked moderator privileges in the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void moderatorRevoked(EntityFullJid participant);
void moderatorRevoked(EntityFullJid participant);
/**
* Called when an owner grants a user ownership on the room. This means that the user
@ -135,7 +135,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was granted ownership on the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void ownershipGranted(EntityFullJid participant);
void ownershipGranted(EntityFullJid participant);
/**
* Called when an owner revokes a user ownership on the room. This means that the user
@ -145,7 +145,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was revoked ownership on the room
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void ownershipRevoked(EntityFullJid participant);
void ownershipRevoked(EntityFullJid participant);
/**
* Called when an owner grants administrator privileges to a user. This means that the user
@ -155,7 +155,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was granted administrator privileges
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void adminGranted(EntityFullJid participant);
void adminGranted(EntityFullJid participant);
/**
* Called when an owner revokes administrator privileges from a user. This means that the user
@ -165,7 +165,7 @@ public interface ParticipantStatusListener {
* @param participant the participant that was revoked administrator privileges
* (e.g. room@conference.jabber.org/nick).
*/
public abstract void adminRevoked(EntityFullJid participant);
void adminRevoked(EntityFullJid participant);
/**
* Called when a participant changed his/her nickname in the room. The new participant's
@ -175,6 +175,6 @@ public interface ParticipantStatusListener {
* (e.g. room@conference.jabber.org/nick).
* @param newNickname the new nickname that the participant decided to use.
*/
public abstract void nicknameChanged(EntityFullJid participant, Resourcepart newNickname);
void nicknameChanged(EntityFullJid participant, Resourcepart newNickname);
}

View file

@ -32,6 +32,6 @@ public interface SubjectUpdatedListener {
* @param subject the new room's subject.
* @param from the user that changed the room's subject or <code>null</code> if the room itself changed the subject.
*/
public abstract void subjectUpdated(String subject, EntityFullJid from);
void subjectUpdated(String subject, EntityFullJid from);
}

View file

@ -34,7 +34,7 @@ public interface UserStatusListener {
* @param actor the moderator that kicked your user from the room (e.g. user@host.org).
* @param reason the reason provided by the actor to kick you from the room.
*/
public abstract void kicked(Jid actor, String reason);
void kicked(Jid actor, String reason);
/**
* Called when a moderator grants voice to your user. This means that you were a visitor in
@ -42,7 +42,7 @@ public interface UserStatusListener {
* all occupants.
*
*/
public abstract void voiceGranted();
void voiceGranted();
/**
* Called when a moderator revokes voice from your user. This means that you were a
@ -50,7 +50,7 @@ public interface UserStatusListener {
* messages to the room occupants.
*
*/
public abstract void voiceRevoked();
void voiceRevoked();
/**
* Called when an administrator or owner banned your user from the room. This means that you
@ -59,21 +59,21 @@ public interface UserStatusListener {
* @param actor the administrator that banned your user (e.g. user@host.org).
* @param reason the reason provided by the administrator to banned you.
*/
public abstract void banned(Jid actor, String reason);
void banned(Jid actor, String reason);
/**
* Called when an administrator grants your user membership to the room. This means that you
* will be able to join the members-only room.
*
*/
public abstract void membershipGranted();
void membershipGranted();
/**
* Called when an administrator revokes your user membership to the room. This means that you
* will not be able to join the members-only room.
*
*/
public abstract void membershipRevoked();
void membershipRevoked();
/**
* Called when an administrator grants moderator privileges to your user. This means that you
@ -81,7 +81,7 @@ public interface UserStatusListener {
* subject plus all the partcipants privileges.
*
*/
public abstract void moderatorGranted();
void moderatorGranted();
/**
* Called when an administrator revokes moderator privileges from your user. This means that
@ -89,7 +89,7 @@ public interface UserStatusListener {
* modify room's subject plus all the partcipants privileges.
*
*/
public abstract void moderatorRevoked();
void moderatorRevoked();
/**
* Called when an owner grants to your user ownership on the room. This means that you
@ -97,7 +97,7 @@ public interface UserStatusListener {
* functions.
*
*/
public abstract void ownershipGranted();
void ownershipGranted();
/**
* Called when an owner revokes from your user ownership on the room. This means that you
@ -105,7 +105,7 @@ public interface UserStatusListener {
* administrative functions.
*
*/
public abstract void ownershipRevoked();
void ownershipRevoked();
/**
* Called when an owner grants administrator privileges to your user. This means that you
@ -113,7 +113,7 @@ public interface UserStatusListener {
* list.
*
*/
public abstract void adminGranted();
void adminGranted();
/**
* Called when an owner revokes administrator privileges from your user. This means that you
@ -121,7 +121,7 @@ public interface UserStatusListener {
* moderator list.
*
*/
public abstract void adminRevoked();
void adminRevoked();
/**
* Called when the room is destroyed.
@ -129,6 +129,6 @@ public interface UserStatusListener {
* @param alternateMUC an alternate MultiUserChat, may be null.
* @param reason the reason why the room was closed, may be null.
*/
public abstract void roomDestroyed(MultiUserChat alternateMUC, String reason);
void roomDestroyed(MultiUserChat alternateMUC, String reason);
}

View file

@ -43,7 +43,7 @@ class SimpleUserSearch extends IQ {
private Form form;
private ReportedData data;
public SimpleUserSearch() {
SimpleUserSearch() {
super(ELEMENT, NAMESPACE);
}