1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2025-12-06 21:21:08 +01:00

More checkstyle whitespace related checks

This commit is contained in:
Florian Schmaus 2017-05-23 16:45:04 +02:00
parent 847890b037
commit ce1cddc722
140 changed files with 583 additions and 512 deletions

View file

@ -126,7 +126,7 @@ public class Chat {
* @param listener a stanza(/packet) listener.
*/
public void addMessageListener(ChatMessageListener listener) {
if(listener == null) {
if (listener == null) {
return;
}
// TODO these references should be weak.
@ -202,7 +202,7 @@ public class Chat {
@Override
public boolean equals(Object obj) {
return obj instanceof Chat
&& threadID.equals(((Chat)obj).getThreadID())
&& participant.equals(((Chat)obj).getParticipant());
&& threadID.equals(((Chat) obj).getThreadID())
&& participant.equals(((Chat) obj).getParticipant());
}
}

View file

@ -164,7 +164,7 @@ public final class ChatManager extends Manager{
chat = getThreadChat(message.getThread());
}
if(chat == null) {
if (chat == null) {
chat = createChat(message);
}
// The chat could not be created, abort here
@ -248,7 +248,7 @@ public final class ChatManager extends Manager{
thread = nextID();
}
Chat chat = threadChats.get(thread);
if(chat != null) {
if (chat != null) {
throw new IllegalArgumentException("ThreadID is already used");
}
chat = createChat(userJID, thread, true);
@ -262,7 +262,7 @@ public final class ChatManager extends Manager{
jidChats.put(userJID, chat);
baseJidChats.put(userJID.asEntityBareJid(), chat);
for(ChatManagerListener listener : chatManagerListeners) {
for (ChatManagerListener listener : chatManagerListeners) {
listener.chatCreated(chat, createdLocally);
}
@ -293,11 +293,11 @@ public final class ChatManager extends Manager{
EntityJid userJID = from.asEntityJidIfPossible();
if (userJID == null) {
LOGGER.warning("Message from JID without localpart: '" +message.toXML() + "'");
LOGGER.warning("Message from JID without localpart: '" + message.toXML() + "'");
return null;
}
String threadID = message.getThread();
if(threadID == null) {
if (threadID == null) {
threadID = nextID();
}
@ -372,9 +372,9 @@ public final class ChatManager extends Manager{
}
void sendMessage(Chat chat, Message message) throws NotConnectedException, InterruptedException {
for(Map.Entry<MessageListener, StanzaFilter> interceptor : interceptors.entrySet()) {
for (Map.Entry<MessageListener, StanzaFilter> interceptor : interceptors.entrySet()) {
StanzaFilter filter = interceptor.getValue();
if(filter != null && filter.accept(message)) {
if (filter != null && filter.accept(message)) {
interceptor.getKey().processMessage(message);
}
}

View file

@ -419,7 +419,7 @@ public final class Roster extends Manager {
* @throws NotConnectedException
* @throws InterruptedException
*/
public void reload() throws NotLoggedInException, NotConnectedException, InterruptedException{
public void reload() throws NotLoggedInException, NotConnectedException, InterruptedException {
final XMPPConnection connection = getAuthenticatedConnectionOrThrow();
RosterPacket packet = new RosterPacket();
@ -1307,7 +1307,7 @@ public final class Roster extends Manager {
// Remove user from the remaining groups.
List<String> oldGroupNames = new ArrayList<String>();
for (RosterGroup group: getGroups()) {
for (RosterGroup group : getGroups()) {
oldGroupNames.add(group.getName());
}
oldGroupNames.removeAll(newGroupNames);
@ -1329,7 +1329,7 @@ public final class Roster extends Manager {
move(user, presenceMap, nonRosterPresenceMap);
deletedEntries.add(user);
for (Entry<String,RosterGroup> e: groups.entrySet()) {
for (Entry<String,RosterGroup> e : groups.entrySet()) {
RosterGroup group = e.getValue();
group.removeEntryLocal(entry);
if (group.getEntryCount() == 0) {

View file

@ -123,7 +123,7 @@ public final class RosterEntry extends Manager {
* @param subscriptionPending TODO
*/
void updateItem(RosterPacket.Item item) {
assert(item != null);
assert (item != null);
this.item = item;
}
@ -145,7 +145,7 @@ public final class RosterEntry extends Manager {
List<RosterGroup> results = new ArrayList<RosterGroup>();
// Loop through all roster groups and find the ones that contain this
// entry. This algorithm should be fine
for (RosterGroup group: roster.getGroups()) {
for (RosterGroup group : roster.getGroups()) {
if (group.contains(this)) {
results.add(group);
}
@ -256,7 +256,7 @@ public final class RosterEntry extends Manager {
return true;
}
if (object != null && object instanceof RosterEntry) {
return getJid().equals(((RosterEntry)object).getJid());
return getJid().equals(((RosterEntry) object).getJid());
}
else {
return false;

View file

@ -41,7 +41,7 @@ public class RosterPacketProvider extends IQProvider<RosterPacket> {
outerloop: while (true) {
int eventType = parser.next();
switch(eventType) {
switch (eventType) {
case XmlPullParser.START_TAG:
String startTag = parser.getName();
switch (startTag) {
@ -53,7 +53,7 @@ public class RosterPacketProvider extends IQProvider<RosterPacket> {
break;
case XmlPullParser.END_TAG:
String endTag = parser.getName();
switch(endTag) {
switch (endTag) {
case IQ.QUERY_ELEMENT:
if (parser.getDepth() == initialDepth) {
break outerloop;
@ -84,7 +84,7 @@ public class RosterPacketProvider extends IQProvider<RosterPacket> {
boolean approved = ParserUtils.getBooleanAttribute(parser, "approved", false);
item.setApproved(approved);
outerloop: while(true) {
outerloop: while (true) {
int eventType = parser.next();
switch (eventType) {
case XmlPullParser.START_TAG:
@ -106,7 +106,7 @@ public class RosterPacketProvider extends IQProvider<RosterPacket> {
}
}
ParserUtils.assertAtEndTag(parser);
assert(item != null);
assert (item != null);
return item;
}
}