mirror of
https://github.com/vanitasvitae/Smack.git
synced 2025-09-10 17:49:38 +02:00
Throw an XMPPException if SASL authentication fails. SMACK-89
git-svn-id: http://svn.igniterealtime.org/svn/repos/smack/trunk@2817 b35dd754-fafc-0310-a699-88a17e54d16e
This commit is contained in:
parent
bb0a864be9
commit
283b0f33f5
3 changed files with 73 additions and 11 deletions
|
@ -69,6 +69,11 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
* Boolean indicating if SASL negotiation has finished and was successful.
|
||||
*/
|
||||
private boolean saslNegotiated = false;
|
||||
/**
|
||||
* Boolean indication if SASL authentication has failed. When failed the server may end
|
||||
* the connection.
|
||||
*/
|
||||
private boolean saslFailed = false;
|
||||
private boolean resourceBinded = false;
|
||||
private boolean sessionSupported = false;
|
||||
|
||||
|
@ -186,12 +191,20 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
|
||||
// Wait until SASL negotiation finishes
|
||||
synchronized (this) {
|
||||
try {
|
||||
wait(30000);
|
||||
} catch (InterruptedException e) {
|
||||
if (!saslNegotiated && !saslFailed) {
|
||||
try {
|
||||
wait(30000);
|
||||
} catch (InterruptedException e) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (saslFailed) {
|
||||
// SASL authentication failed and the server may have closed the connection
|
||||
// so throw an exception
|
||||
throw new XMPPException("SASL authentication failed");
|
||||
}
|
||||
|
||||
if (saslNegotiated) {
|
||||
// We now need to bind a resource for the connection
|
||||
// Open a new stream and wait for the response
|
||||
|
@ -249,8 +262,11 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
return new NonSASLAuthentication(connection)
|
||||
.authenticate(username, password, resource);
|
||||
}
|
||||
|
||||
} catch (Exception e) {
|
||||
}
|
||||
catch (XMPPException e) {
|
||||
throw e;
|
||||
}
|
||||
catch (Exception e) {
|
||||
e.printStackTrace();
|
||||
// SASL authentication failed so try a Non-SASL authentication
|
||||
return new NonSASLAuthentication(connection)
|
||||
|
@ -280,7 +296,7 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
|
||||
// Wait until SASL negotiation finishes
|
||||
synchronized (this) {
|
||||
if (!saslNegotiated) {
|
||||
if (!saslNegotiated && !saslFailed) {
|
||||
try {
|
||||
wait(5000);
|
||||
} catch (InterruptedException e) {
|
||||
|
@ -288,6 +304,12 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
}
|
||||
}
|
||||
|
||||
if (saslFailed) {
|
||||
// SASL authentication failed and the server may have closed the connection
|
||||
// so throw an exception
|
||||
throw new XMPPException("SASL authentication failed");
|
||||
}
|
||||
|
||||
if (saslNegotiated) {
|
||||
// Bind a resource for this connection and
|
||||
return bindResourceAndEstablishSession(null);
|
||||
|
@ -366,6 +388,15 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
this.serverMechanisms = mechanisms;
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns true if the user was able to authenticate with the server usins SASL.
|
||||
*
|
||||
* @return true if the user was able to authenticate with the server usins SASL.
|
||||
*/
|
||||
public boolean isAuthenticated() {
|
||||
return saslNegotiated;
|
||||
}
|
||||
|
||||
/**
|
||||
* The server is challenging the SASL authentication we just sent. Forward the challenge
|
||||
* to the current SASLMechanism we are using. The SASLMechanism will send a response to
|
||||
|
@ -391,6 +422,18 @@ public class SASLAuthentication implements UserAuthentication {
|
|||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Notification message saying that SASL authentication has failed. The server may have
|
||||
* closed the connection depending on the number of possible retries.
|
||||
*/
|
||||
void authenticationFailed() {
|
||||
synchronized (this) {
|
||||
saslFailed = true;
|
||||
// Wake up the thread that is waiting in the #authenticate method
|
||||
notify();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Notification message saying that the server requires the client to bind a
|
||||
* resource to the stream.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue