1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-12-18 08:51:08 +01:00

Bump "Error Prone" to 2.0.15

and fix a few things :)
This commit is contained in:
Florian Schmaus 2017-02-11 16:16:41 +01:00
parent ef0af66b21
commit 4c646436a5
246 changed files with 1122 additions and 124 deletions

View file

@ -122,6 +122,7 @@ public class Affiliation implements ExtensionElement
return ELEMENT;
}
@Override
public String getNamespace() {
return namespace.getXmlns();
}

View file

@ -49,6 +49,7 @@ public class ConfigurationEvent extends NodeExtension implements EmbeddedPacketE
return form;
}
@Override
public List<ExtensionElement> getExtensions()
{
if (getConfiguration() == null)

View file

@ -610,6 +610,7 @@ public class ConfigureForm extends Form
*
* @return The node title
*/
@Override
public String getTitle()
{
return getFieldValue(ConfigureNodeFields.title);
@ -620,6 +621,7 @@ public class ConfigureForm extends Form
*
* @param title The node title
*/
@Override
public void setTitle(String title)
{
addField(ConfigureNodeFields.title, FormField.Type.text_single);

View file

@ -58,6 +58,7 @@ public class EventElement implements EmbeddedPacketExtension
return type;
}
@Override
public List<ExtensionElement> getExtensions()
{
return Arrays.asList(new ExtensionElement[]{getEvent()});
@ -68,11 +69,13 @@ public class EventElement implements EmbeddedPacketExtension
return ext;
}
@Override
public String getElementName()
{
return "event";
}
@Override
public String getNamespace()
{
return PubSubNamespace.EVENT.getXmlns();

View file

@ -48,8 +48,8 @@ public class ItemsExtension extends NodeExtension implements EmbeddedPacketExten
/** A retract element, which has an optional <b>notify</b> attribute when publishing deletions. */
retract(PubSubElementType.RETRACT, "notify");
private PubSubElementType elem;
private String att;
private final PubSubElementType elem;
private final String att;
private ItemsElementType(PubSubElementType nodeElement, String attribute)
{
@ -130,6 +130,7 @@ public class ItemsExtension extends NodeExtension implements EmbeddedPacketExten
return type;
}
@Override
@SuppressWarnings("unchecked")
public List<ExtensionElement> getExtensions()
{

View file

@ -604,6 +604,7 @@ abstract public class Node
listener = eventListener;
}
@Override
@SuppressWarnings({ "rawtypes", "unchecked" })
public void processStanza(Stanza packet)
{
@ -631,6 +632,7 @@ abstract public class Node
listener = eventListener;
}
@Override
public void processStanza(Stanza packet)
{
// CHECKSTYLE:OFF
@ -667,7 +669,7 @@ abstract public class Node
*
* @author Robin Collier
*/
public class NodeConfigTranslator implements StanzaListener
public static class NodeConfigTranslator implements StanzaListener
{
private NodeConfigListener listener;
@ -676,12 +678,11 @@ abstract public class Node
listener = eventListener;
}
@Override
public void processStanza(Stanza packet)
{
// CHECKSTYLE:OFF
EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
ConfigurationEvent config = (ConfigurationEvent)event.getEvent();
// CHECKSTYLE:ON
listener.handleNodeConfiguration(config);
}
@ -712,6 +713,7 @@ abstract public class Node
&& "item".equals(secondLevelElement);
}
@Override
public boolean acceptSpecific(Message message) {
EventElement event = EventElement.from(message);

View file

@ -65,16 +65,19 @@ public class NodeExtension implements ExtensionElement
return node;
}
@Override
public String getElementName()
{
return element.getElementName();
}
@Override
public String getNamespace()
{
return element.getNamespace().getXmlns();
}
@Override
public CharSequence toXML()
{
return '<' + getElementName() + (node == null ? "" : " node='" + node + '\'') + "/>";

View file

@ -51,8 +51,8 @@ public enum PubSubElementType
SUBSCRIPTIONS("subscriptions", PubSubNamespace.BASIC),
UNSUBSCRIBE("unsubscribe", PubSubNamespace.BASIC);
private String eName;
private PubSubNamespace nSpace;
private final String eName;
private final PubSubNamespace nSpace;
private PubSubElementType(String elemName, PubSubNamespace ns)
{

View file

@ -45,16 +45,19 @@ public class RetractItem implements ExtensionElement
return id;
}
@Override
public String getElementName()
{
return "retract";
}
@Override
public String getNamespace()
{
return PubSubNamespace.EVENT.getXmlns();
}
@Override
public String toXML()
{
return "<retract id='" + id + "'/>";

View file

@ -45,11 +45,13 @@ public class SimplePayload implements ExtensionElement
ns = namespace;
}
@Override
public String getElementName()
{
return elemName;
}
@Override
public String getNamespace()
{
return ns;

View file

@ -133,6 +133,7 @@ public class Subscription extends NodeExtension
return configRequired;
}
@Override
public String toXML()
{
StringBuilder builder = new StringBuilder("<subscription");