Move Packet 'properties' from core to extensions

Code for Jive's packet properties should not be in 'core'. Also de-serializing input from network causes some security implications, it is therefore disabled as default.
2025-12-13 06:21:08 +01:00 · 2014-04-26 15:43:58 +02:00 · 2014-04-26 15:43:58 +02:00 · 6e08a10186
commit 6e08a10186
parent c2b214f8d8
11 changed files with 516 additions and 281 deletions
--- a/extensions/src/test/java/org/jivesoftware/smackx/jiveproperties/JivePropertiesExtensionTest.java
+++ b/extensions/src/test/java/org/jivesoftware/smackx/jiveproperties/JivePropertiesExtensionTest.java
@ -0,0 +1,66 @@
+/**
+ *
+ * Copyright 2014 Florian Schmaus
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jivesoftware.smackx.jiveproperties;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+import org.jivesoftware.smack.packet.Message;
+import org.jivesoftware.smack.test.util.TestUtils;
+import org.jivesoftware.smack.util.PacketParserUtils;
+import org.jivesoftware.smackx.InitExtensions;
+import org.jivesoftware.smackx.jiveproperties.packet.JivePropertiesExtension;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+public class JivePropertiesExtensionTest extends InitExtensions {
+
+    @Before
+    public void setUp() {
+        JivePropertiesManager.setJavaObjectEnabled(true);
+    }
+
+    @After
+    public void tearDown() {
+        JivePropertiesManager.setJavaObjectEnabled(false);
+    }
+
+    @Test
+    public void checkProvider() throws Exception {
+        // @formatter:off
+        String properties = "<message from='romeo@example.net/orchard' to='juliet@example.com/balcony'>"
+                        + "<body>Neither, fair saint, if either thee dislike.</body>"
+                        + "<properties xmlns='http://www.jivesoftware.com/xmlns/xmpp/properties'>"
+                        + "<property>"
+                        + "<name>FooBar</name>"
+                        + "<value type='integer'>42</value>"
+                        + "</property>"
+                        + "</properties>"
+                        + "</message>";
+        // @formatter:on
+
+        Message message = PacketParserUtils.parseMessage(TestUtils.getMessageParser(properties));
+        JivePropertiesExtension jpe = (JivePropertiesExtension) message.getExtension(JivePropertiesExtension.NAMESPACE);
+        assertNotNull(jpe);
+
+        Integer integer = (Integer) jpe.getProperty("FooBar");
+        assertNotNull(integer);
+        int fourtytwo = integer;
+        assertEquals(42, fourtytwo);
+    }
+}