vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-09-09 09:09:38 +02:00
Code Issues Releases Wiki Activity

Make Objects.requireNonNull() throw IllegalArgumentException

Browse source 
and not NullPointerException. Altough this differs from
java.util.Objects behavior, throwing an IllegalArgumentException
appears more sensible and makes it easier to catch it in Smack's
parsing function.
This commit is contained in:
Florian Schmaus 2019-06-11 12:32:42 +02:00
parent 9bb36fc63c
commit 818ee8a727
5 changed files with 33 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleContentTest.java
View file

@ -32,7 +32,7 @@ import org.junit.Test;
*/
public class JingleContentTest extends SmackTestSuite {
@Test(expected = NullPointerException.class)
@Test(expected = IllegalArgumentException.class)
public void emptyBuilderThrowsTest() {
JingleContent.Builder builder = JingleContent.getBuilder();
builder.build();

2
smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleTest.java
View file

@ -41,7 +41,7 @@ public class JingleTest extends SmackTestSuite {
builder.build();
}
@Test(expected = NullPointerException.class)
@Test(expected = IllegalArgumentException.class)
public void onlySessionIdBuilderTest() {
String sessionId = "testSessionId";