1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-09-09 17:19:39 +02:00

Add FinalClass checkstyle check

And mark affected classes final.
This commit is contained in:
Florian Schmaus 2015-04-06 10:45:12 +02:00
parent 5ae1fbd25a
commit b4694ec152
72 changed files with 80 additions and 79 deletions

View file

@ -128,7 +128,7 @@ public class MultipleAddresses implements ExtensionElement {
return buf;
}
public static class Address implements NamedElement {
public static final class Address implements NamedElement {
public static final String ELEMENT = "address";

View file

@ -40,7 +40,7 @@ import org.jivesoftware.smackx.iqprivate.PrivateDataManager;
*
* @author Alexander Wenckus
*/
public class BookmarkManager {
public final class BookmarkManager {
private static final Map<XMPPConnection, BookmarkManager> bookmarkManagerMap = new WeakHashMap<XMPPConnection, BookmarkManager>();
static {

View file

@ -79,7 +79,7 @@ import org.jxmpp.jid.Jid;
*
* @author Henning Staib
*/
public class InBandBytestreamManager implements BytestreamManager {
public final class InBandBytestreamManager implements BytestreamManager {
/**
* Stanzas that can be used to encapsulate In-Band Bytestream data packets.

View file

@ -68,7 +68,7 @@ import org.jivesoftware.smack.SmackException;
*
* @author Henning Staib
*/
public class Socks5Proxy {
public final class Socks5Proxy {
private static final Logger LOGGER = Logger.getLogger(Socks5Proxy.class.getName());
/* SOCKS5 proxy singleton */

View file

@ -71,7 +71,7 @@ import java.security.NoSuchAlgorithmException;
* @author Florian Schmaus
* @see <a href="http://www.xmpp.org/extensions/xep-0115.html">XEP-0115: Entity Capabilities</a>
*/
public class EntityCapsManager extends Manager {
public final class EntityCapsManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(EntityCapsManager.class.getName());
public static final String NAMESPACE = CapsExtension.NAMESPACE;

View file

@ -49,7 +49,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
* @see org.jivesoftware.smackx.chatstates.ChatState
* @see org.jivesoftware.smackx.chatstates.packet.ChatStateExtension
*/
public class ChatStateManager extends Manager {
public final class ChatStateManager extends Manager {
public static final String NAMESPACE = "http://jabber.org/protocol/chatstates";
private static final Map<XMPPConnection, ChatStateManager> INSTANCES =

View file

@ -60,7 +60,7 @@ import org.jxmpp.jid.Jid;
*
* @author Gabriel Guardincerri
*/
public class AdHocCommandManager extends Manager {
public final class AdHocCommandManager extends Manager {
public static final String NAMESPACE = "http://jabber.org/protocol/commands";
private static final Logger LOGGER = Logger.getLogger(AdHocCommandManager.class.getName());

View file

@ -24,7 +24,7 @@ import org.jivesoftware.smackx.delay.DelayInformationManager;
/**
* Filters stanza with delay information, ie. stanzas that got delayed for some reason
*/
public class DelayedStanzaFilter implements StanzaFilter {
public final class DelayedStanzaFilter implements StanzaFilter {
public static final StanzaFilter INSTANCE = new DelayedStanzaFilter();

View file

@ -63,7 +63,7 @@ import java.util.logging.Logger;
*
* @author Gaston Dombiak
*/
public class ServiceDiscoveryManager extends Manager {
public final class ServiceDiscoveryManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(ServiceDiscoveryManager.class.getName());

View file

@ -43,7 +43,7 @@ import java.util.concurrent.CopyOnWriteArrayList;
* @author Alexander Wenckus
*
*/
public class FileTransferManager extends Manager {
public final class FileTransferManager extends Manager {
private static final Map<XMPPConnection, FileTransferManager> INSTANCES = new WeakHashMap<XMPPConnection, FileTransferManager>();

View file

@ -52,7 +52,7 @@ import org.jxmpp.jid.Jid;
* @author Alexander Wenckus
* @see <a href="http://xmpp.org/extensions/xep-0096.html">XEP-0096: SI File Transfer</a>
*/
public class FileTransferNegotiator extends Manager {
public final class FileTransferNegotiator extends Manager {
public static final String SI_NAMESPACE = "http://jabber.org/protocol/si";
public static final String SI_PROFILE_FILE_TRANSFER_NAMESPACE = "http://jabber.org/protocol/si/profile/file-transfer";

View file

@ -105,7 +105,7 @@ public class IBBTransferNegotiator extends StreamNegotiator {
/**
* Derive from InBandBytestreamRequest to access protected constructor.
*/
private static class ByteStreamRequest extends InBandBytestreamRequest {
private static final class ByteStreamRequest extends InBandBytestreamRequest {
private ByteStreamRequest(InBandBytestreamManager manager, Open byteStreamRequest) {
super(manager, byteStreamRequest);

View file

@ -119,7 +119,7 @@ public class Socks5TransferNegotiator extends StreamNegotiator {
/**
* Derive from Socks5BytestreamRequest to access protected constructor.
*/
private static class ByteStreamRequest extends Socks5BytestreamRequest {
private static final class ByteStreamRequest extends Socks5BytestreamRequest {
private ByteStreamRequest(Socks5BytestreamManager manager, Bytestream byteStreamRequest) {
super(manager, byteStreamRequest);

View file

@ -28,7 +28,7 @@ import org.jivesoftware.smack.packet.Message;
import org.jivesoftware.smackx.geoloc.packet.GeoLocation;
import org.jxmpp.jid.Jid;
public class GeoLocationManager extends Manager {
public final class GeoLocationManager extends Manager {
private static final Map<XMPPConnection, GeoLocationManager> INSTANCES = new WeakHashMap<XMPPConnection, GeoLocationManager>();

View file

@ -33,7 +33,7 @@ import org.jivesoftware.smack.util.XmlStringBuilder;
* @see <a href="http://www.xmpp.org/extensions/xep-0080.html">XEP-0080</a>
* @author Ishan Khanna
*/
public class GeoLocation implements Serializable, ExtensionElement {
public final class GeoLocation implements Serializable, ExtensionElement {
private static final long serialVersionUID = 1L;
public static final String NAMESPACE = "http://jabber.org/protocol/geoloc";

View file

@ -90,7 +90,7 @@ import org.jxmpp.jid.Jid;
* Activity</a>
*/
public class LastActivityManager extends Manager {
public final class LastActivityManager extends Manager {
private static final Map<XMPPConnection, LastActivityManager> instances = new WeakHashMap<XMPPConnection, LastActivityManager>();
// private static final PacketFilter IQ_GET_LAST_FILTER = new AndFilter(IQTypeFilter.GET,
// new StanzaTypeFilter(LastActivity.class));

View file

@ -59,7 +59,7 @@ import java.util.WeakHashMap;
*
* @author Matt Tucker
*/
public class PrivateDataManager extends Manager {
public final class PrivateDataManager extends Manager {
private static final Map<XMPPConnection, PrivateDataManager> instances = new WeakHashMap<XMPPConnection, PrivateDataManager>();
public static synchronized PrivateDataManager getInstanceFor(XMPPConnection connection) {

View file

@ -41,7 +41,7 @@ import org.jivesoftware.smackx.iqregister.packet.Registration;
*
* @author Matt Tucker
*/
public class AccountManager extends Manager {
public final class AccountManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(AccountManager.class.getName());

View file

@ -100,7 +100,7 @@ public class Registration extends IQ {
return xml;
}
public static class Feature implements ExtensionElement {
public static final class Feature implements ExtensionElement {
public static final String ELEMENT = "register";
public static final String NAMESPACE = "http://jabber.org/features/iq-register";

View file

@ -53,7 +53,7 @@ import org.jxmpp.jid.Jid;
*
* @author Georg Lukas
*/
public class VersionManager extends Manager {
public final class VersionManager extends Manager {
private static final Map<XMPPConnection, VersionManager> INSTANCES = new WeakHashMap<XMPPConnection, VersionManager>();
private static Version defaultVersion;

View file

@ -55,7 +55,7 @@ import org.jxmpp.jid.DomainBareJid;
import org.jxmpp.jid.Jid;
import org.jxmpp.jid.JidWithLocalpart;
public class MultiUserChatManager extends Manager {
public final class MultiUserChatManager extends Manager {
private final static String DISCO_NODE = MUCInitialPresence.NAMESPACE + "#rooms";
private static final Logger LOGGER = Logger.getLogger(MultiUserChatManager.class.getName());

View file

@ -413,7 +413,7 @@ public class MUCUser implements ExtensionElement {
*
* @author Gaston Dombiak
*/
public static class Status implements NamedElement {
public static final class Status implements NamedElement {
public static final String ELEMENT = "status";
private static final Map<Integer, Status> statusMap = new HashMap<Integer, Status>(8);

View file

@ -60,7 +60,7 @@ import org.jxmpp.jid.Jid;
* @author Florian Schmaus
* @see <a href="http://www.xmpp.org/extensions/xep-0199.html">XEP-0199:XMPP Ping</a>
*/
public class PingManager extends Manager {
public final class PingManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(PingManager.class.getName());
private static final Map<XMPPConnection, PingManager> INSTANCES = new WeakHashMap<XMPPConnection, PingManager>();

View file

@ -62,7 +62,7 @@ import org.jivesoftware.smackx.privacy.packet.PrivacyItem;
* @author Francisco Vives
* @see <a href="http://xmpp.org/extensions/xep-0016.html">XEP-16: Privacy Lists</a>
*/
public class PrivacyListManager extends Manager {
public final class PrivacyListManager extends Manager {
public static final String NAMESPACE = Privacy.NAMESPACE;
public static final StanzaFilter PRIVACY_FILTER = new StanzaTypeFilter(Privacy.class);

View file

@ -20,7 +20,7 @@ import org.jivesoftware.smack.filter.FlexibleStanzaTypeFilter;
import org.jivesoftware.smack.packet.IQ.Type;
import org.jivesoftware.smackx.privacy.packet.Privacy;
public class SetActiveListFilter extends FlexibleStanzaTypeFilter<Privacy> {
public final class SetActiveListFilter extends FlexibleStanzaTypeFilter<Privacy> {
public static final SetActiveListFilter INSTANCE = new SetActiveListFilter();

View file

@ -20,7 +20,7 @@ import org.jivesoftware.smack.filter.FlexibleStanzaTypeFilter;
import org.jivesoftware.smack.packet.IQ.Type;
import org.jivesoftware.smackx.privacy.packet.Privacy;
public class SetDefaultListFilter extends FlexibleStanzaTypeFilter<Privacy> {
public final class SetDefaultListFilter extends FlexibleStanzaTypeFilter<Privacy> {
public static final SetDefaultListFilter INSTANCE = new SetDefaultListFilter();

View file

@ -66,7 +66,7 @@ import org.jxmpp.jid.Jid;
* @author Georg Lukas
* @see <a href="http://xmpp.org/extensions/xep-0184.html">XEP-0184: Message Delivery Receipts</a>
*/
public class DeliveryReceiptManager extends Manager {
public final class DeliveryReceiptManager extends Manager {
private static final StanzaFilter MESSAGES_WITH_DEVLIERY_RECEIPT_REQUEST = new AndFilter(StanzaTypeFilter.MESSAGE,
new StanzaExtensionFilter(new DeliveryReceiptRequest()));

View file

@ -36,7 +36,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
import org.jivesoftware.smackx.time.packet.Time;
import org.jxmpp.jid.Jid;
public class EntityTimeManager extends Manager {
public final class EntityTimeManager extends Manager {
private static final Map<XMPPConnection, EntityTimeManager> INSTANCES = new WeakHashMap<XMPPConnection, EntityTimeManager>();

View file

@ -33,7 +33,7 @@ import org.jivesoftware.smackx.vcardtemp.packet.VCard;
import org.jxmpp.jid.BareJid;
import org.jxmpp.jid.Jid;
public class VCardManager extends Manager {
public final class VCardManager extends Manager {
public static final String NAMESPACE = VCard.NAMESPACE;
public static final String ELEMENT = VCard.ELEMENT;

View file

@ -30,7 +30,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
import org.jivesoftware.smackx.xdata.packet.DataForm;
import org.jxmpp.jid.Jid;
public class XDataManager extends Manager {
public final class XDataManager extends Manager {
/**
* The value of {@link DataForm#NAMESPACE}.

View file

@ -37,7 +37,7 @@ import org.jivesoftware.smack.SmackException;
*
* @author Henning Staib
*/
public class Socks5TestProxy {
public final class Socks5TestProxy {
private static final Logger LOGGER = Logger.getLogger(Socks5TestProxy.class.getName());
/* SOCKS5 proxy singleton */