1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-09-09 17:19:39 +02:00

More checkstyle whitespace related checks

This commit is contained in:
Florian Schmaus 2017-05-23 16:45:04 +02:00
parent 847890b037
commit ce1cddc722
140 changed files with 583 additions and 512 deletions

View file

@ -84,7 +84,7 @@ public class ServiceAdministrationManager extends Manager {
passwordVerifyField.addValue(password);
command.next(answerForm);
assert(command.isCompleted());
assert (command.isCompleted());
}
public RemoteCommand deleteUser() {
@ -112,6 +112,6 @@ public class ServiceAdministrationManager extends Manager {
accountJids.addValues(JidUtil.toStringList(jidsToDelete));
command.next(answerForm);
assert(command.isCompleted());
assert (command.isCompleted());
}
}

View file

@ -228,7 +228,7 @@ public class AMPExtension implements ExtensionElement {
String getName();
String getValue();
static final String ATTRIBUTE_NAME="condition";
static final String ATTRIBUTE_NAME = "condition";
}
/**
@ -265,7 +265,7 @@ public class AMPExtension implements ExtensionElement {
*/
notify;
public static final String ATTRIBUTE_NAME="action";
public static final String ATTRIBUTE_NAME = "action";
}
/**

View file

@ -82,7 +82,7 @@ public class BoBData {
private void setContentBinaryIfRequired() {
if (contentBinary == null) {
assert(StringUtils.isNotEmpty(contentString));
assert (StringUtils.isNotEmpty(contentString));
contentBinary = Base64.decode(contentString);
}
}

View file

@ -118,9 +118,9 @@ public final class BookmarkManager {
BookmarkedConference bookmark
= new BookmarkedConference(name, jid, isAutoJoin, nickname, password);
List<BookmarkedConference> conferences = bookmarks.getBookmarkedConferences();
if(conferences.contains(bookmark)) {
if (conferences.contains(bookmark)) {
BookmarkedConference oldConference = conferences.get(conferences.indexOf(bookmark));
if(oldConference.isShared()) {
if (oldConference.isShared()) {
throw new IllegalArgumentException("Cannot modify shared bookmark");
}
oldConference.setAutoJoin(isAutoJoin);
@ -149,10 +149,10 @@ public final class BookmarkManager {
public void removeBookmarkedConference(EntityBareJid jid) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
retrieveBookmarks();
Iterator<BookmarkedConference> it = bookmarks.getBookmarkedConferences().iterator();
while(it.hasNext()) {
while (it.hasNext()) {
BookmarkedConference conference = it.next();
if(conference.getJid().equals(jid)) {
if(conference.isShared()) {
if (conference.getJid().equals(jid)) {
if (conference.isShared()) {
throw new IllegalArgumentException("Conference is shared and can't be removed");
}
it.remove();
@ -192,9 +192,9 @@ public final class BookmarkManager {
retrieveBookmarks();
BookmarkedURL bookmark = new BookmarkedURL(URL, name, isRSS);
List<BookmarkedURL> urls = bookmarks.getBookmarkedURLS();
if(urls.contains(bookmark)) {
if (urls.contains(bookmark)) {
BookmarkedURL oldURL = urls.get(urls.indexOf(bookmark));
if(oldURL.isShared()) {
if (oldURL.isShared()) {
throw new IllegalArgumentException("Cannot modify shared bookmarks");
}
oldURL.setName(name);
@ -219,10 +219,10 @@ public final class BookmarkManager {
public void removeBookmarkedURL(String bookmarkURL) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
retrieveBookmarks();
Iterator<BookmarkedURL> it = bookmarks.getBookmarkedURLS().iterator();
while(it.hasNext()) {
while (it.hasNext()) {
BookmarkedURL bookmark = it.next();
if(bookmark.getURL().equalsIgnoreCase(bookmarkURL)) {
if(bookmark.isShared()) {
if (bookmark.getURL().equalsIgnoreCase(bookmarkURL)) {
if (bookmark.isShared()) {
throw new IllegalArgumentException("Cannot delete a shared bookmark.");
}
it.remove();
@ -249,8 +249,8 @@ public final class BookmarkManager {
}
private Bookmarks retrieveBookmarks() throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
synchronized(bookmarkLock) {
if(bookmarks == null) {
synchronized (bookmarkLock) {
if (bookmarks == null) {
bookmarks = (Bookmarks) privateDataManager.getPrivateData("storage",
"storage:bookmarks");
}

View file

@ -115,10 +115,10 @@ public class BookmarkedConference implements SharedBookmark {
@Override
public boolean equals(Object obj) {
if(obj == null || !(obj instanceof BookmarkedConference)) {
if (obj == null || !(obj instanceof BookmarkedConference)) {
return false;
}
BookmarkedConference conference = (BookmarkedConference)obj;
BookmarkedConference conference = (BookmarkedConference) obj;
return conference.getJid().equals(jid);
}

View file

@ -86,10 +86,10 @@ public class BookmarkedURL implements SharedBookmark {
@Override
public boolean equals(Object obj) {
if(!(obj instanceof BookmarkedURL)) {
if (!(obj instanceof BookmarkedURL)) {
return false;
}
BookmarkedURL url = (BookmarkedURL)obj;
BookmarkedURL url = (BookmarkedURL) obj;
return url.getURL().equalsIgnoreCase(URL);
}

View file

@ -177,7 +177,7 @@ public class Bookmarks implements PrivateData {
buf.halfOpenElement(ELEMENT).xmlnsAttribute(NAMESPACE).rightAngleBracket();
for (BookmarkedURL urlStorage : getBookmarkedURLS()) {
if(urlStorage.isShared()) {
if (urlStorage.isShared()) {
continue;
}
buf.halfOpenElement("url").attribute("name", urlStorage.getName()).attribute("url", urlStorage.getURL());
@ -187,7 +187,7 @@ public class Bookmarks implements PrivateData {
// Add Conference additions
for (BookmarkedConference conference : getBookmarkedConferences()) {
if(conference.isShared()) {
if (conference.isShared()) {
continue;
}
buf.halfOpenElement("conference");
@ -260,7 +260,7 @@ public class Bookmarks implements PrivateData {
boolean done = false;
while (!done) {
int eventType = parser.next();
if(eventType == XmlPullParser.START_TAG
if (eventType == XmlPullParser.START_TAG
&& "shared_bookmark".equals(parser.getName())) {
urlStore.setShared(true);
}
@ -291,7 +291,7 @@ public class Bookmarks implements PrivateData {
else if (eventType == XmlPullParser.START_TAG && "password".equals(parser.getName())) {
conf.setPassword(parser.nextText());
}
else if(eventType == XmlPullParser.START_TAG
else if (eventType == XmlPullParser.START_TAG
&& "shared_bookmark".equals(parser.getName())) {
conf.setShared(true);
}

View file

@ -64,7 +64,7 @@ class DataListener extends AbstractIqRequestHandler {
ibbSession.processIQPacket(data);
}
}
catch (NotConnectedException|InterruptedException e) {
catch (NotConnectedException | InterruptedException e) {
return null;
}
return null;

View file

@ -415,7 +415,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
*/
@Override
public Socks5BytestreamSession establishSession(Jid targetJID, String sessionID)
throws IOException, InterruptedException, NoResponseException, SmackException, XMPPException{
throws IOException, InterruptedException, NoResponseException, SmackException, XMPPException {
XMPPConnection connection = connection();
XMPPErrorException discoveryException = null;
// check if target supports SOCKS5 Bytestream
@ -556,7 +556,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
try {
proxyInfo = serviceDiscoveryManager.discoverInfo(item.getEntityID());
}
catch (NoResponseException|XMPPErrorException e) {
catch (NoResponseException | XMPPErrorException e) {
// blacklist errornous server
proxyBlacklist.add(item.getEntityID());
continue;

View file

@ -280,7 +280,7 @@ public final class Socks5Proxy {
* @return true if the address was removed.
*/
public boolean removeLocalAddress(String address) {
synchronized(localAddresses) {
synchronized (localAddresses) {
return localAddresses.remove(address);
}
}
@ -311,7 +311,7 @@ public final class Socks5Proxy {
if (addresses == null) {
throw new IllegalArgumentException("list must not be null");
}
synchronized(localAddresses) {
synchronized (localAddresses) {
localAddresses.clear();
localAddresses.addAll(addresses);
}

View file

@ -224,7 +224,7 @@ public class Bytestream extends IQ {
@Override
protected IQChildElementXmlStringBuilder getIQChildElementBuilder(IQChildElementXmlStringBuilder xml) {
switch(getType()) {
switch (getType()) {
case set:
xml.optAttribute("sid", getSessionID());
xml.optAttribute("mode", getMode());

View file

@ -717,7 +717,7 @@ public final class EntityCapsManager extends Manager {
throw new AssertionError(e);
}
byte[] digest;
synchronized(md) {
synchronized (md) {
digest = md.digest(bytes);
}
String version = Base64.encodeToString(digest);

View file

@ -105,10 +105,10 @@ public final class ChatStateManager extends Manager {
* @throws InterruptedException
*/
public void setCurrentState(ChatState newState, org.jivesoftware.smack.chat.Chat chat) throws NotConnectedException, InterruptedException {
if(chat == null || newState == null) {
if (chat == null || newState == null) {
throw new IllegalArgumentException("Arguments cannot be null.");
}
if(!updateChatState(chat, newState)) {
if (!updateChatState(chat, newState)) {
return;
}
Message message = new Message();

View file

@ -140,7 +140,7 @@ public final class ServiceDiscoveryManager extends Manager {
response.addItems(nodeInformationProvider.getNodeItems());
// Add packet extensions
response.addExtensions(nodeInformationProvider.getNodePacketExtensions());
} else if(discoverItems.getNode() != null) {
} else if (discoverItems.getNode() != null) {
// Return <item-not-found/> error since client doesn't contain
// the specified node
response.setType(IQ.Type.error);
@ -761,7 +761,7 @@ public final class ServiceDiscoveryManager extends Manager {
try {
// Get the disco items and send the disco packet to each server item
items = discoverItems(serviceName);
} catch(XMPPErrorException e) {
} catch (XMPPErrorException e) {
LOGGER.log(Level.WARNING, "Could not discover items about service", e);
return serviceDiscoInfo;
}

View file

@ -74,7 +74,7 @@ public class DiscoverInfoProvider extends IQProvider<DiscoverInfo> {
if (parser.getName().equals("feature")) {
// Create a new feature and add it to the discovered info.
boolean notADuplicateFeature = discoverInfo.addFeature(variable);
assert(notADuplicateFeature);
assert (notADuplicateFeature);
}
if (parser.getName().equals("query")) {
done = true;

View file

@ -73,7 +73,7 @@ public class FaultTolerantNegotiator extends StreamNegotiator {
private StreamNegotiator determineNegotiator(Stanza streamInitiation) {
if (streamInitiation instanceof Bytestream) {
return primaryNegotiator;
} else if (streamInitiation instanceof Open){
} else if (streamInitiation instanceof Open) {
return secondaryNegotiator;
} else {
throw new IllegalStateException("Unknown stream initation type");

View file

@ -308,7 +308,7 @@ public abstract class FileTransfer {
* Return the length of bytes written out to the stream.
* @return the amount in bytes written out.
*/
public long getAmountWritten(){
public long getAmountWritten() {
return amountWritten;
}

View file

@ -162,7 +162,7 @@ public class OutgoingFileTransfer extends FileTransfer {
final long fileSize, final String description,
final NegotiationProgress progress)
{
if(progress == null) {
if (progress == null) {
throw new IllegalArgumentException("Callback progress cannot be null.");
}
checkTransferThread();
@ -295,7 +295,7 @@ public class OutgoingFileTransfer extends FileTransfer {
* @param fileSize the size of the file that is transferred
* @param description a description for the file to transfer.
*/
public synchronized void sendStream(final InputStream in, final String fileName, final long fileSize, final String description){
public synchronized void sendStream(final InputStream in, final String fileName, final long fileSize, final String description) {
checkTransferThread();
setFileInfo(fileName, fileSize);
@ -409,7 +409,7 @@ public class OutgoingFileTransfer extends FileTransfer {
@Override
protected boolean updateStatus(Status oldStatus, Status newStatus) {
boolean isUpdated = super.updateStatus(oldStatus, newStatus);
if(callback != null && isUpdated) {
if (callback != null && isUpdated) {
callback.statusUpdated(oldStatus, newStatus);
}
return isUpdated;
@ -419,7 +419,7 @@ public class OutgoingFileTransfer extends FileTransfer {
protected void setStatus(Status status) {
Status oldStatus = getStatus();
super.setStatus(status);
if(callback != null) {
if (callback != null) {
callback.statusUpdated(oldStatus, status);
}
}
@ -427,7 +427,7 @@ public class OutgoingFileTransfer extends FileTransfer {
@Override
protected void setException(Exception exception) {
super.setException(exception);
if(callback != null) {
if (callback != null) {
callback.errorEstablishingStream(exception);
}
}

View file

@ -112,10 +112,10 @@ public class Occupant {
@Override
public boolean equals(Object obj) {
if(!(obj instanceof Occupant)) {
if (!(obj instanceof Occupant)) {
return false;
}
Occupant occupant = (Occupant)obj;
Occupant occupant = (Occupant) obj;
return jid.equals(occupant.jid);
}

View file

@ -247,7 +247,7 @@ public class MUCUser implements ExtensionElement {
* @author Gaston Dombiak
*/
public static class Invite implements NamedElement {
public static final String ELEMENT ="invite";
public static final String ELEMENT = "invite";
private final String reason;

View file

@ -95,9 +95,9 @@ public final class PEPManager extends Manager {
public void processStanza(Stanza stanza) {
Message message = (Message) stanza;
EventElement event = EventElement.from(stanza);
assert(event != null);
assert (event != null);
EntityBareJid from = message.getFrom().asEntityBareJidIfPossible();
assert(from != null);
assert (from != null);
for (PEPListener listener : pepListeners) {
listener.eventReceived(from, event, message);
}

View file

@ -575,7 +575,7 @@ public final class PrivacyListManager extends Manager {
* @throws NotConnectedException
* @throws InterruptedException
*/
public boolean isSupported() throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException{
public boolean isSupported() throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
return ServiceDiscoveryManager.getInstanceFor(connection()).serverSupportsFeature(NAMESPACE);
}
}

View file

@ -46,11 +46,11 @@ public class Privacy extends IQ {
public static final String NAMESPACE = "jabber:iq:privacy";
/** declineActiveList is true when the user declines the use of the active list **/
private boolean declineActiveList=false;
private boolean declineActiveList = false;
/** activeName is the name associated with the active list set for the session **/
private String activeName;
/** declineDefaultList is true when the user declines the use of the default list **/
private boolean declineDefaultList=false;
private boolean declineDefaultList = false;
/** defaultName is the name of the default list that applies to the user as a whole **/
private String defaultName;
/** itemLists holds the set of privacy items classified in lists. It is a map where the

View file

@ -139,7 +139,7 @@ public class Affiliation implements ExtensionElement
*/
public boolean isAffiliationModification() {
if (jid != null && affiliation != null) {
assert(node == null && namespace == PubSubNamespace.OWNER);
assert (node == null && namespace == PubSubNamespace.OWNER);
return true;
}
return false;

View file

@ -55,6 +55,6 @@ public class ConfigurationEvent extends NodeExtension implements EmbeddedPacketE
if (getConfiguration() == null)
return Collections.emptyList();
else
return Arrays.asList(((ExtensionElement)getConfiguration().getDataFormToSend()));
return Arrays.asList(((ExtensionElement) getConfiguration().getDataFormToSend()));
}
}

View file

@ -61,7 +61,7 @@ public class EventElement implements EmbeddedPacketExtension
@Override
public List<ExtensionElement> getExtensions()
{
return Arrays.asList(new ExtensionElement[]{getEvent()});
return Arrays.asList(new ExtensionElement[] {getEvent()});
}
public NodeExtension getEvent()

View file

@ -134,7 +134,7 @@ public class ItemsExtension extends NodeExtension implements EmbeddedPacketExten
@SuppressWarnings("unchecked")
public List<ExtensionElement> getExtensions()
{
return (List<ExtensionElement>)getItems();
return (List<ExtensionElement>) getItems();
}
/**

View file

@ -242,7 +242,7 @@ public class LeafNode extends Node
public <T extends Item> void publish(T item) throws NotConnectedException, InterruptedException
{
Collection<T> items = new ArrayList<T>(1);
items.add((T)(item == null ? new Item() : item));
items.add((T) (item == null ? new Item() : item));
publish(items);
}
@ -320,7 +320,7 @@ public class LeafNode extends Node
public <T extends Item> void send(T item) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException
{
Collection<T> items = new ArrayList<T>(1);
items.add((item == null ? (T)new Item() : item));
items.add((item == null ? (T) new Item() : item));
send(items);
}

View file

@ -573,7 +573,7 @@ abstract public class Node
private static List<String> getSubscriptionIds(Stanza packet)
{
HeadersExtension headers = (HeadersExtension)packet.getExtension("headers", "http://jabber.org/protocol/shim");
HeadersExtension headers = (HeadersExtension) packet.getExtension("headers", "http://jabber.org/protocol/shim");
List<String> values = null;
if (headers != null)
@ -608,10 +608,8 @@ abstract public class Node
@SuppressWarnings({ "rawtypes", "unchecked" })
public void processStanza(Stanza packet)
{
// CHECKSTYLE:OFF
EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
// CHECKSTYLE:ON
ItemsExtension itemsElem = (ItemsExtension)event.getEvent();
EventElement event = (EventElement) packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
ItemsExtension itemsElem = (ItemsExtension) event.getEvent();
ItemPublishEvent eventItems = new ItemPublishEvent(itemsElem.getNode(), itemsElem.getItems(), getSubscriptionIds(packet), DelayInformationManager.getDelayTimestamp(packet));
listener.handlePublishedItems(eventItems);
}
@ -681,8 +679,8 @@ abstract public class Node
@Override
public void processStanza(Stanza packet)
{
EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
ConfigurationEvent config = (ConfigurationEvent)event.getEvent();
EventElement event = (EventElement) packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
ConfigurationEvent config = (ConfigurationEvent) event.getEvent();
listener.handleNodeConfiguration(config);
}
@ -735,7 +733,7 @@ abstract public class Node
if (embedEvent instanceof EmbeddedPacketExtension)
{
List<ExtensionElement> secondLevelList = ((EmbeddedPacketExtension)embedEvent).getExtensions();
List<ExtensionElement> secondLevelList = ((EmbeddedPacketExtension) embedEvent).getExtensions();
// XEP-0060 allows no elements on second level for notifications. See schema or
// for example § 4.3:

View file

@ -73,7 +73,7 @@ public enum PubSubElementType
public static PubSubElementType valueOfFromElemName(String elemName, String namespace)
{
int index = namespace.lastIndexOf('#');
String fragment = (index == -1 ? null : namespace.substring(index+1));
String fragment = (index == -1 ? null : namespace.substring(index + 1));
if (fragment != null)
{

View file

@ -61,7 +61,7 @@ public enum PubSubNamespace
if (index != -1)
{
String suffix = ns.substring(ns.lastIndexOf('#')+1);
String suffix = ns.substring(ns.lastIndexOf('#') + 1);
return valueOf(suffix.toUpperCase(Locale.US));
}
else

View file

@ -35,7 +35,7 @@ import org.jivesoftware.smackx.pubsub.AffiliationsExtension;
@Override
protected AffiliationsExtension createReturnExtension(String currentElement, String currentNamespace, Map<String, String> attributeMap, List<? extends ExtensionElement> content)
{
return new AffiliationsExtension((List<Affiliation>)content);
return new AffiliationsExtension((List<Affiliation>) content);
}
}

View file

@ -39,6 +39,6 @@ public class ConfigEventProvider extends EmbeddedExtensionProvider<Configuration
if (content.size() == 0)
return new ConfigurationEvent(attMap.get("node"));
else
return new ConfigurationEvent(attMap.get("node"), new ConfigureForm((DataForm)content.iterator().next()));
return new ConfigurationEvent(attMap.get("node"), new ConfigureForm((DataForm) content.iterator().next()));
}
}

View file

@ -36,6 +36,6 @@ public class EventProvider extends EmbeddedExtensionProvider<EventElement>
@Override
protected EventElement createReturnExtension(String currentElement, String currentNamespace, Map<String, String> attMap, List<? extends ExtensionElement> content)
{
return new EventElement(EventElementType.valueOf(content.get(0).getElementName()), (NodeExtension)content.get(0));
return new EventElement(EventElementType.valueOf(content.get(0).getElementName()), (NodeExtension) content.get(0));
}
}

View file

@ -37,6 +37,6 @@ public class FormNodeProvider extends EmbeddedExtensionProvider<FormNode>
@Override
protected FormNode createReturnExtension(String currentElement, String currentNamespace, Map<String, String> attributeMap, List<? extends ExtensionElement> content)
{
return new FormNode(FormNodeType.valueOfFromElementName(currentElement, currentNamespace), attributeMap.get("node"), new Form((DataForm)content.iterator().next()));
return new FormNode(FormNodeType.valueOfFromElementName(currentElement, currentNamespace), attributeMap.get("node"), new Form((DataForm) content.iterator().next()));
}
}

View file

@ -36,7 +36,7 @@ public class SubscriptionsProvider extends EmbeddedExtensionProvider<Subscriptio
@Override
protected SubscriptionsExtension createReturnExtension(String currentElement, String currentNamespace, Map<String, String> attributeMap, List<? extends ExtensionElement> content)
{
return new SubscriptionsExtension(attributeMap.get("node"), (List<Subscription>)content);
return new SubscriptionsExtension(attributeMap.get("node"), (List<Subscription>) content);
}
}

View file

@ -86,7 +86,7 @@ public class ReportedData {
}
public ReportedData(){
public ReportedData() {
// Allow for model creation of ReportedData.
}
@ -94,7 +94,7 @@ public class ReportedData {
* Adds a new <code>Row</code>.
* @param row the new row to add.
*/
public void addRow(Row row){
public void addRow(Row row) {
rows.add(row);
}
@ -102,7 +102,7 @@ public class ReportedData {
* Adds a new <code>Column</code>.
* @param column the column to add.
*/
public void addColumn(Column column){
public void addColumn(Column column) {
columns.add(column);
}
@ -206,7 +206,7 @@ public class ReportedData {
* @return the values of the field whose variable matches the requested variable.
*/
public List<String> getValues(String variable) {
for(Field field : getFields()) {
for (Field field : getFields()) {
if (variable.equalsIgnoreCase(field.getVariable())) {
return field.getValues();
}

View file

@ -172,16 +172,16 @@ public class UserSearch extends SimpleIQ {
FormField field = new FormField(name);
// Handle hard coded values.
if(name.equals("first")){
if (name.equals("first")) {
field.setLabel("First Name");
}
else if(name.equals("last")){
else if (name.equals("last")) {
field.setLabel("Last Name");
}
else if(name.equals("email")){
else if (name.equals("email")) {
field.setLabel("Email Address");
}
else if(name.equals("nick")){
else if (name.equals("nick")) {
field.setLabel("Nickname");
}

View file

@ -87,7 +87,7 @@ public class StreamInitiationProvider extends IQProvider<StreamInitiation> {
done = true;
} else if (elementName.equals("file")) {
long fileSize = 0;
if(size != null && size.trim().length() !=0){
if (size != null && size.trim().length() != 0) {
try {
fileSize = Long.parseLong(size);
}

View file

@ -205,7 +205,7 @@ public class Form {
}
private static void validateThatFieldIsText(FormField field) {
switch(field.getType()) {
switch (field.getType()) {
case text_multi:
case text_private:
case text_single:
@ -444,7 +444,7 @@ public class Form {
if (isSubmitType()) {
// Create a new DataForm that contains only the answered fields
DataForm dataFormToSend = new DataForm(getType());
for(FormField field : getFields()) {
for (FormField field : getFields()) {
if (!field.getValues().isEmpty()) {
dataFormToSend.addField(field);
}

View file

@ -163,7 +163,7 @@ public class Socks5ByteStreamManagerTest {
catch (FeatureNotSupportedException e) {
assertTrue(e.getFeature().equals("SOCKS5 Bytestream"));
assertTrue(e.getJid().equals(targetJID));
} catch(Exception e) {
} catch (Exception e) {
fail(e.getMessage());
}

View file

@ -148,7 +148,7 @@ public class Socks5ProxyTest {
proxy.addLocalAddress("same");
int sameCount = 0;
for(String localAddress : proxy.getLocalAddresses()) {
for (String localAddress : proxy.getLocalAddresses()) {
if ("same".equals(localAddress)) {
sameCount++;
}

View file

@ -176,7 +176,7 @@ public final class Socks5TestProxy {
*/
@SuppressWarnings("WaitNotInLoop")
public Socket getSocket(String digest) {
synchronized(this) {
synchronized (this) {
if (!startupComplete) {
try {
wait(5000);

View file

@ -93,7 +93,7 @@ public class ForwardedTest {
assertEquals("forwarded", parser.getName());
}
@Test(expected=Exception.class)
@Test(expected = Exception.class)
public void forwardedEmptyTest() throws Exception {
XmlPullParser parser;
String control;

View file

@ -75,32 +75,32 @@ public class GeoLocationTest extends InitExtensions {
// @formatter:off
final String geoLocationMessageString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<accuracy>23</accuracy>"
+"<alt>1000</alt>"
+"<area>Delhi</area>"
+"<bearing>10</bearing>"
+"<building>Small Building</building>"
+"<country>India</country>"
+"<countrycode>IN</countrycode>"
+"<description>My Description</description>"
+"<error>90</error>"
+"<floor>top</floor>"
+"<lat>25.098345</lat>"
+"<locality>awesome</locality>"
+"<lon>77.992034</lon>"
+"<postalcode>110085</postalcode>"
+"<region>North</region>"
+"<room>small</room>"
+"<speed>250.0</speed>"
+"<street>Wall Street</street>"
+"<text>Unit Testing GeoLocation</text>"
+"<timestamp>2004-02-19</timestamp>"
+"<tzo>+5:30</tzo>"
+"<uri>http://xmpp.org</uri>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<accuracy>23</accuracy>"
+ "<alt>1000</alt>"
+ "<area>Delhi</area>"
+ "<bearing>10</bearing>"
+ "<building>Small Building</building>"
+ "<country>India</country>"
+ "<countrycode>IN</countrycode>"
+ "<description>My Description</description>"
+ "<error>90</error>"
+ "<floor>top</floor>"
+ "<lat>25.098345</lat>"
+ "<locality>awesome</locality>"
+ "<lon>77.992034</lon>"
+ "<postalcode>110085</postalcode>"
+ "<region>North</region>"
+ "<room>small</room>"
+ "<speed>250.0</speed>"
+ "<street>Wall Street</street>"
+ "<text>Unit Testing GeoLocation</text>"
+ "<timestamp>2004-02-19</timestamp>"
+ "<tzo>+5:30</tzo>"
+ "<uri>http://xmpp.org</uri>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationMessageString);

View file

@ -35,32 +35,32 @@ public class GeoLocationProviderTest extends InitExtensions {
public void testGeoLocationProviderWithNoDatumSet() throws Exception {
// @formatter:off
final String geoLocationString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<accuracy>23</accuracy>"
+"<alt>1000</alt>"
+"<area>Delhi</area>"
+"<bearing>10</bearing>"
+"<building>Small Building</building>"
+"<country>India</country>"
+"<countrycode>IN</countrycode>"
+"<description>My Description</description>"
+"<error>90</error>"
+"<floor>top</floor>"
+"<lat>25.098345</lat>"
+"<locality>awesome</locality>"
+"<lon>77.992034</lon>"
+"<postalcode>110085</postalcode>"
+"<region>North</region>"
+"<room>small</room>"
+"<speed>250.0</speed>"
+"<street>Wall Street</street>"
+"<text>Unit Testing GeoLocation</text>"
+"<timestamp>2004-02-19</timestamp>"
+"<tzo>+5:30</tzo>"
+"<uri>http://xmpp.org</uri>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<accuracy>23</accuracy>"
+ "<alt>1000</alt>"
+ "<area>Delhi</area>"
+ "<bearing>10</bearing>"
+ "<building>Small Building</building>"
+ "<country>India</country>"
+ "<countrycode>IN</countrycode>"
+ "<description>My Description</description>"
+ "<error>90</error>"
+ "<floor>top</floor>"
+ "<lat>25.098345</lat>"
+ "<locality>awesome</locality>"
+ "<lon>77.992034</lon>"
+ "<postalcode>110085</postalcode>"
+ "<region>North</region>"
+ "<room>small</room>"
+ "<speed>250.0</speed>"
+ "<street>Wall Street</street>"
+ "<text>Unit Testing GeoLocation</text>"
+ "<timestamp>2004-02-19</timestamp>"
+ "<tzo>+5:30</tzo>"
+ "<uri>http://xmpp.org</uri>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationString);
@ -101,33 +101,33 @@ public class GeoLocationProviderTest extends InitExtensions {
// @formatter:off
final String geoLocationString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<accuracy>23</accuracy>"
+"<alt>1000</alt>"
+"<area>Delhi</area>"
+"<bearing>10</bearing>"
+"<building>Small Building</building>"
+"<country>India</country>"
+"<countrycode>IN</countrycode>"
+"<datum>Test Datum</datum>"
+"<description>My Description</description>"
+"<error>90</error>"
+"<floor>top</floor>"
+"<lat>25.098345</lat>"
+"<locality>awesome</locality>"
+"<lon>77.992034</lon>"
+"<postalcode>110085</postalcode>"
+"<region>North</region>"
+"<room>small</room>"
+"<speed>250.0</speed>"
+"<street>Wall Street</street>"
+"<text>Unit Testing GeoLocation</text>"
+"<timestamp>2004-02-19</timestamp>"
+"<tzo>+5:30</tzo>"
+"<uri>http://xmpp.org</uri>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<accuracy>23</accuracy>"
+ "<alt>1000</alt>"
+ "<area>Delhi</area>"
+ "<bearing>10</bearing>"
+ "<building>Small Building</building>"
+ "<country>India</country>"
+ "<countrycode>IN</countrycode>"
+ "<datum>Test Datum</datum>"
+ "<description>My Description</description>"
+ "<error>90</error>"
+ "<floor>top</floor>"
+ "<lat>25.098345</lat>"
+ "<locality>awesome</locality>"
+ "<lon>77.992034</lon>"
+ "<postalcode>110085</postalcode>"
+ "<region>North</region>"
+ "<room>small</room>"
+ "<speed>250.0</speed>"
+ "<street>Wall Street</street>"
+ "<text>Unit Testing GeoLocation</text>"
+ "<timestamp>2004-02-19</timestamp>"
+ "<tzo>+5:30</tzo>"
+ "<uri>http://xmpp.org</uri>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationString);
@ -168,11 +168,11 @@ public class GeoLocationProviderTest extends InitExtensions {
// @formatter:off
final String geoLocationString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<error>90</error>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<error>90</error>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationString);
@ -188,11 +188,11 @@ public class GeoLocationProviderTest extends InitExtensions {
// @formatter:off
final String geoLocationString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<accuracy>90</accuracy>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<accuracy>90</accuracy>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationString);
@ -208,12 +208,12 @@ public class GeoLocationProviderTest extends InitExtensions {
// @formatter:off
final String geoLocationString = "<message from='portia@merchantofvenice.lit'"
+" to='bassanio@merchantofvenice.lit'>"
+"<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+"<accuracy>90</accuracy>"
+"<error>100</error>"
+"</geoloc>"
+"</message>";
+ " to='bassanio@merchantofvenice.lit'>"
+ "<geoloc xmlns='http://jabber.org/protocol/geoloc'>"
+ "<accuracy>90</accuracy>"
+ "<error>100</error>"
+ "</geoloc>"
+ "</message>";
// @formatter:on
Message messageWithGeoLocation = (Message) PacketParserUtils.parseStanza(geoLocationString);

View file

@ -82,7 +82,7 @@ public class ConfigureFormTest extends InitExtensions
}
}
@Test (expected=SmackException.class)
@Test(expected = SmackException.class)
public void getConfigFormWithTimeout() throws XMPPException, SmackException, InterruptedException
{
ThreadedDummyConnection con = new ThreadedDummyConnection();

View file

@ -111,11 +111,11 @@ public class ItemValidationTest extends InitExtensions {
assertEquals(EventElementType.items, event.getEventType());
assertEquals(1, event.getExtensions().size());
assertTrue(event.getExtensions().get(0) instanceof ItemsExtension);
assertEquals(1, ((ItemsExtension)event.getExtensions().get(0)).items.size());
assertEquals(1, ((ItemsExtension) event.getExtensions().get(0)).items.size());
ExtensionElement itemExt = ((ItemsExtension)event.getExtensions().get(0)).items.get(0);
ExtensionElement itemExt = ((ItemsExtension) event.getExtensions().get(0)).items.get(0);
assertTrue(itemExt instanceof Item);
assertEquals("testid1", ((Item)itemExt).getId());
assertEquals("testid1", ((Item) itemExt).getId());
}
@Test
@ -137,10 +137,10 @@ public class ItemValidationTest extends InitExtensions {
Stanza message = PacketParserUtils.parseMessage(parser);
ExtensionElement eventExt = message.getExtension(PubSubNamespace.EVENT.getXmlns());
EventElement event = (EventElement) eventExt;
ExtensionElement itemExt = ((ItemsExtension)event.getExtensions().get(0)).items.get(0);
ExtensionElement itemExt = ((ItemsExtension) event.getExtensions().get(0)).items.get(0);
assertTrue(itemExt instanceof PayloadItem<?>);
PayloadItem<?> item = (PayloadItem<?>)itemExt;
PayloadItem<?> item = (PayloadItem<?>) itemExt;
assertEquals("testid1", item.getId());
assertTrue(item.getPayload() instanceof SimplePayload);
@ -184,10 +184,10 @@ public class ItemValidationTest extends InitExtensions {
Stanza message = PacketParserUtils.parseMessage(parser);
ExtensionElement eventExt = message.getExtension(PubSubNamespace.EVENT.getXmlns());
EventElement event = (EventElement) eventExt;
ExtensionElement itemExt = ((ItemsExtension)event.getExtensions().get(0)).items.get(0);
ExtensionElement itemExt = ((ItemsExtension) event.getExtensions().get(0)).items.get(0);
assertTrue(itemExt instanceof PayloadItem<?>);
PayloadItem<?> item = (PayloadItem<?>)itemExt;
PayloadItem<?> item = (PayloadItem<?>) itemExt;
assertEquals("testid1", item.getId());
assertTrue(item.getPayload() instanceof SimplePayload);
@ -222,15 +222,15 @@ public class ItemValidationTest extends InitExtensions {
assertEquals(EventElementType.items, event.getEventType());
assertEquals(1, event.getExtensions().size());
assertTrue(event.getExtensions().get(0) instanceof ItemsExtension);
assertEquals(1, ((ItemsExtension)event.getExtensions().get(0)).items.size());
assertEquals(1, ((ItemsExtension) event.getExtensions().get(0)).items.size());
ExtensionElement itemExt = ((ItemsExtension)event.getExtensions().get(0)).items.get(0);
ExtensionElement itemExt = ((ItemsExtension) event.getExtensions().get(0)).items.get(0);
assertTrue(itemExt instanceof PayloadItem<?>);
PayloadItem<?> item = (PayloadItem<?>)itemExt;
PayloadItem<?> item = (PayloadItem<?>) itemExt;
assertEquals("testid1", item.getId());
assertTrue(item.getPayload() instanceof SimplePayload);
assertXMLEqual(itemContent, ((SimplePayload)item.getPayload()).toXML().toString());
assertXMLEqual(itemContent, ((SimplePayload) item.getPayload()).toXML().toString());
}
}

View file

@ -60,7 +60,7 @@ public class DeliveryReceiptTest extends InitExtensions {
parser = PacketParserUtils.getParserFor(control);
Message p = PacketParserUtils.parseMessage(parser);
DeliveryReceiptRequest drr = (DeliveryReceiptRequest)p.getExtension(
DeliveryReceiptRequest drr = (DeliveryReceiptRequest) p.getExtension(
DeliveryReceiptRequest.ELEMENT, DeliveryReceipt.NAMESPACE);
assertNotNull(drr);

View file

@ -124,7 +124,7 @@ public class DataLayoutTest {
assertEquals("Label - & \u00E9 \u00E1 ", layout.getLabel());
section = (Section) layout.getPageLayout().get(1);
assertEquals("section Label - & \u00E9 \u00E1 ", section.getLabel());
Text text = (Text)layout.getPageLayout().get(2);
Text text = (Text) layout.getPageLayout().get(2);
assertEquals("PageText - & \u00E9 \u00E1 ", text.getText());
section = (Section) layout.getPageLayout().get(3);
assertEquals("<html>Number of Persons by<br/> Nationality and Status</html>", section.getLabel());
@ -155,7 +155,7 @@ public class DataLayoutTest {
assertEquals("Label - & \u00E9 \u00E1 ", layout.getLabel());
Section section = (Section) layout.getPageLayout().get(1);
assertEquals("section Label - & \u00E9 \u00E1 ", section.getLabel());
Text text = (Text)layout.getPageLayout().get(2);
Text text = (Text) layout.getPageLayout().get(2);
assertEquals("PageText - & \u00E9 \u00E1 ", text.getText());
section = (Section) layout.getPageLayout().get(3);
assertEquals("<html>Number of Persons by<br/> Nationality and Status</html>", section.getLabel());

View file

@ -122,7 +122,7 @@ public class DataValidationTest {
assertEquals(TEST_OUTPUT_RANGE2, output);
}
@Test(expected=NumberFormatException.class)
@Test(expected = NumberFormatException.class)
public void testRangeFailure() throws IOException, XmlPullParserException {
XmlPullParser parser = getParser(TEST_OUTPUT_FAIL);
DataValidationProvider.parse(parser);