JET is close to working

smack-experimental/src/main/java/org/jivesoftware/smackx/ciphers/Aes256GcmNoPadding.java

@@ -33,7 +33,7 @@ public class Aes256GcmNoPadding extends AesGcmNoPadding {
     public Aes256GcmNoPadding(byte[] keyAndIv) throws NoSuchProviderException, InvalidAlgorithmParameterException,
             NoSuchAlgorithmException, InvalidKeyException, NoSuchPaddingException {
         super(AesGcmNoPadding.copyOfRange(keyAndIv, 0, keyAndIv.length / 2), //Key
-                AesGcmNoPadding.copyOfRange(keyAndIv, keyAndIv.length / 2, keyAndIv.length / 2)); //IV
+                AesGcmNoPadding.copyOfRange(keyAndIv, keyAndIv.length / 2, keyAndIv.length)); //IV
     }
 
     @Override

smack-experimental/src/main/java/org/jivesoftware/smackx/ciphers/AesGcmNoPadding.java

@@ -62,15 +62,13 @@ public abstract class AesGcmNoPadding {
 
     public AesGcmNoPadding(byte[] key, byte[] iv) throws NoSuchPaddingException, NoSuchAlgorithmException,
             NoSuchProviderException, InvalidAlgorithmParameterException, InvalidKeyException {
-        this.length = key.length;
+        this.length = key.length * 8;
         this.key = key;
         this.iv = iv;
 
-        int bytes = length / 8;
-
-        keyAndIv = new byte[2 * bytes];
-        System.arraycopy(key, 0, keyAndIv, 0, bytes);
-        System.arraycopy(iv, 0, keyAndIv, bytes, bytes);
+        keyAndIv = new byte[key.length + iv.length];
+        System.arraycopy(key, 0, keyAndIv, 0, key.length);
+        System.arraycopy(iv, 0, keyAndIv, key.length, iv.length);
 
         cipher = Cipher.getInstance(cipherMode, "BC");
         SecretKeySpec keySpec = new SecretKeySpec(key, keyType);

smack-experimental/src/main/java/org/jivesoftware/smackx/jet/JetManager.java

@@ -18,13 +18,15 @@ package org.jivesoftware.smackx.jet;
 
 import java.io.File;
 import java.util.HashMap;
-import java.util.Map;
 import java.util.WeakHashMap;
+import java.util.logging.Logger;
 
 import org.jivesoftware.smack.Manager;
 import org.jivesoftware.smack.XMPPConnection;
+import org.jivesoftware.smack.provider.ExtensionElementProvider;
 import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
 import org.jivesoftware.smackx.jet.internal.JetSecurity;
+import org.jivesoftware.smackx.jet.provider.JetSecurityProvider;
 import org.jivesoftware.smackx.jft.JingleFileTransferManager;
 import org.jivesoftware.smackx.jft.controller.OutgoingFileOfferController;
 import org.jivesoftware.smackx.jft.internal.JingleOutgoingFileOffer;
@@ -43,13 +45,17 @@ import org.jxmpp.jid.FullJid;
  */
 public final class JetManager extends Manager implements JingleDescriptionManager {
 
+    private static final Logger LOGGER = Logger.getLogger(JetManager.class.getName());
+
     private static final WeakHashMap<XMPPConnection, JetManager> INSTANCES = new WeakHashMap<>();
-    private static final Map<String, JingleEncryptionMethod> encryptionMethods = new HashMap<>();
+    private static final HashMap<String, JingleEncryptionMethod> encryptionMethods = new HashMap<>();
+    private static final HashMap<String, ExtensionElementProvider<?>> encryptionMethodProviders = new HashMap<>();
 
     private final JingleManager jingleManager;
 
     static {
         JingleManager.addJingleSecurityAdapter(new JetSecurityAdapter());
+        JingleManager.addJingleSecurityProvider(new JetSecurityProvider());
     }
 
     private JetManager(XMPPConnection connection) {
@@ -105,6 +111,18 @@ public final class JetManager extends Manager implements JingleDescriptionManage
         return encryptionMethods.get(namespace);
     }
 
+    public static void registerEncryptionMethodProvider(String namespace, ExtensionElementProvider<?> provider) {
+        encryptionMethodProviders.put(namespace, provider);
+    }
+
+    public static void removeEncryptionMethodProvider(String namespace) {
+        encryptionMethodProviders.remove(namespace);
+    }
+
+    public static ExtensionElementProvider<?> getEncryptionMethodProvider(String namespace) {
+        return encryptionMethodProviders.get(namespace);
+    }
+
     @Override
     public String getNamespace() {
         return JetSecurity.NAMESPACE;

smack-experimental/src/main/java/org/jivesoftware/smackx/jet/JingleEncryptionMethodManager.java

@@ -1,42 +0,0 @@
-/**
- *
- * Copyright 2017 Paul Schaub
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jivesoftware.smackx.jet;
-
-import java.util.HashMap;
-
-import org.jivesoftware.smack.packet.ExtensionElement;
-import org.jivesoftware.smack.provider.ExtensionElementProvider;
-
-/**
- * Manager where JingleEncryptionMethods can register their SecurityKeyTransportProviders.
- */
-public final class JingleEncryptionMethodManager {
-
-    public static HashMap<String, ExtensionElementProvider<ExtensionElement>> securityKeyTransportProviders = new HashMap<>();
-
-    private JingleEncryptionMethodManager() {
-        // $(man true)
-    }
-
-    public static void registerSecurityKeyTransportProvider(String namespace, ExtensionElementProvider<ExtensionElement> provider) {
-        securityKeyTransportProviders.put(namespace, provider);
-    }
-
-    public static ExtensionElementProvider<ExtensionElement> getSecurityKeyTransportProvider(String namespace) {
-        return securityKeyTransportProviders.get(namespace);
-    }
-}

smack-experimental/src/main/java/org/jivesoftware/smackx/jet/internal/JetSecurity.java

@@ -20,14 +20,18 @@ import java.security.InvalidAlgorithmParameterException;
 import java.security.InvalidKeyException;
 import java.security.NoSuchAlgorithmException;
 import java.security.NoSuchProviderException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import javax.crypto.NoSuchPaddingException;
 
 import org.jivesoftware.smack.SmackException;
+import org.jivesoftware.smack.XMPPConnection;
 import org.jivesoftware.smack.XMPPException;
 import org.jivesoftware.smack.packet.ExtensionElement;
 import org.jivesoftware.smackx.bytestreams.BytestreamSession;
 import org.jivesoftware.smackx.ciphers.Aes256GcmNoPadding;
 import org.jivesoftware.smackx.ciphers.AesGcmNoPadding;
+import org.jivesoftware.smackx.jet.JetManager;
 import org.jivesoftware.smackx.jet.JingleEncryptionMethod;
 import org.jivesoftware.smackx.jet.element.JetSecurityElement;
 import org.jivesoftware.smackx.jingle.callbacks.JingleSecurityCallback;
@@ -41,6 +45,7 @@ import org.jxmpp.jid.FullJid;
  * Created by vanitas on 22.07.17.
  */
 public class JetSecurity extends JingleSecurity<JetSecurityElement> {
+    private static final Logger LOGGER = Logger.getLogger(JetSecurity.class.getName());
 
     public static final String NAMESPACE_V0 = "urn:xmpp:jingle:jet:0";
     public static final String NAMESPACE = NAMESPACE_V0;
@@ -75,6 +80,7 @@ public class JetSecurity extends JingleSecurity<JetSecurityElement> {
             SmackException.NotConnectedException, SmackException.NoResponseException, NoSuchAlgorithmException,
             InvalidAlgorithmParameterException, NoSuchProviderException, InvalidKeyException, NoSuchPaddingException {
         byte[] keyAndIv = method.decryptJingleTransfer(sender, child);
+        LOGGER.log(Level.INFO, "Transported JET Key has length: " + keyAndIv.length);
         aesKey = new Aes256GcmNoPadding(keyAndIv);
     }
 
@@ -103,6 +109,32 @@ public class JetSecurity extends JingleSecurity<JetSecurityElement> {
         callback.onSecurityReady(securityBytestreamSession);
     }
 
+    @Override
+    public String getNamespace() {
+        return NAMESPACE;
+    }
+
+    @Override
+    public void prepare(XMPPConnection connection, FullJid sender) {
+        if (getParent().getParent().isInitiator()) {
+            return;
+        }
+
+        if (aesKey != null) {
+            return;
+        }
+
+        JingleEncryptionMethod method = JetManager.getInstanceFor(connection).getEncryptionMethod(getMethodNamespace());
+        if (method == null) {
+            throw new AssertionError("No JingleEncryptionMethodManager found for " + getMethodNamespace());
+        }
+        try {
+            decryptEncryptionKey(method, sender);
+        } catch (InterruptedException | NoSuchPaddingException | InvalidKeyException | NoSuchProviderException | InvalidAlgorithmParameterException | NoSuchAlgorithmException | SmackException.NoResponseException | SmackException.NotConnectedException | XMPPException.XMPPErrorException | JingleEncryptionMethod.JingleEncryptionException e) {
+            LOGGER.log(Level.SEVERE, "Could not decrypt security key: " + e, e);
+        }
+    }
+
     public String getMethodNamespace() {
         return methodNamespace;
     }

smack-experimental/src/main/java/org/jivesoftware/smackx/jet/provider/JetSecurityProvider.java

@@ -22,28 +22,29 @@ import java.util.logging.Logger;
 import org.jivesoftware.smack.packet.ExtensionElement;
 import org.jivesoftware.smack.provider.ExtensionElementProvider;
 import org.jivesoftware.smack.util.Objects;
-import org.jivesoftware.smackx.jet.JingleEncryptionMethodManager;
+import org.jivesoftware.smackx.jet.JetManager;
 import org.jivesoftware.smackx.jet.element.JetSecurityElement;
 import org.jivesoftware.smackx.jet.internal.JetSecurity;
+import org.jivesoftware.smackx.jingle.provider.JingleContentSecurityProvider;
 
 import org.xmlpull.v1.XmlPullParser;
 
 /**
  * Provider for the Jingle security element for XEP-XXXX (Jingle Encrypted Transfers).
  */
-public class JetSecurityProvider extends ExtensionElementProvider<JetSecurityElement> {
+public class JetSecurityProvider extends JingleContentSecurityProvider<JetSecurityElement> {
     private static final Logger LOGGER = Logger.getLogger(JetSecurityProvider.class.getName());
 
     @Override
     public JetSecurityElement parse(XmlPullParser parser, int initialDepth) throws Exception {
-        String name = parser.getAttributeValue(JetSecurity.NAMESPACE, JetSecurityElement.ATTR_NAME);
-        String type = parser.getAttributeValue(JetSecurity.NAMESPACE, JetSecurityElement.ATTR_TYPE);
+        String name = parser.getAttributeValue("", JetSecurityElement.ATTR_NAME);
+        String type = parser.getAttributeValue("", JetSecurityElement.ATTR_TYPE);
         ExtensionElement child;
 
         Objects.requireNonNull(type);
 
-        ExtensionElementProvider<ExtensionElement> encryptionElementProvider =
-                JingleEncryptionMethodManager.getSecurityKeyTransportProvider(type);
+        ExtensionElementProvider<?> encryptionElementProvider =
+                JetManager.getEncryptionMethodProvider(type);
 
         if (encryptionElementProvider != null) {
             child = encryptionElementProvider.parse(parser);
@@ -54,4 +55,9 @@ public class JetSecurityProvider extends ExtensionElementProvider<JetSecurityEle
 
         return new JetSecurityElement(name, child);
     }
+
+    @Override
+    public String getNamespace() {
+        return JetSecurity.NAMESPACE;
+    }
 }

smack-experimental/src/main/java/org/jivesoftware/smackx/jft/JingleFileTransferManager.java

@@ -21,6 +21,8 @@ import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.WeakHashMap;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import org.jivesoftware.smack.Manager;
 import org.jivesoftware.smack.SmackException;
@@ -45,7 +47,6 @@ import org.jivesoftware.smackx.jingle.JingleTransportManager;
 import org.jivesoftware.smackx.jingle.components.JingleContent;
 import org.jivesoftware.smackx.jingle.components.JingleSession;
 import org.jivesoftware.smackx.jingle.element.JingleContentElement;
-import org.jivesoftware.smackx.jingle.provider.JingleContentProviderManager;
 import org.jivesoftware.smackx.jingle.util.Role;
 
 import org.jxmpp.jid.FullJid;
@@ -54,6 +55,7 @@ import org.jxmpp.jid.FullJid;
  * Created by vanitas on 22.07.17.
  */
 public final class JingleFileTransferManager extends Manager implements JingleDescriptionManager {
+    private static final Logger LOGGER = Logger.getLogger(JingleFileTransferManager.class.getName());
 
     private static final WeakHashMap<XMPPConnection, JingleFileTransferManager> INSTANCES = new WeakHashMap<>();
     private final JingleManager jingleManager;
@@ -65,6 +67,7 @@ public final class JingleFileTransferManager extends Manager implements JingleDe
 
     static {
         JingleManager.addJingleDescriptionAdapter(new JingleFileTransferAdapter());
+        JingleManager.addJingleDescriptionProvider(new JingleFileTransferProvider());
     }
 
     private JingleFileTransferManager(XMPPConnection connection) {
@@ -72,7 +75,6 @@ public final class JingleFileTransferManager extends Manager implements JingleDe
         ServiceDiscoveryManager.getInstanceFor(connection).addFeature(getNamespace());
         jingleManager = JingleManager.getInstanceFor(connection);
         jingleManager.addJingleDescriptionManager(this);
-        JingleContentProviderManager.addJingleContentDescriptionProvider(getNamespace(), new JingleFileTransferProvider());
     }
 
     public static JingleFileTransferManager getInstanceFor(XMPPConnection connection) {
@@ -127,6 +129,9 @@ public final class JingleFileTransferManager extends Manager implements JingleDe
     }
 
     public void notifyIncomingFileOfferListeners(JingleIncomingFileOffer offer) {
+        LOGGER.log(Level.INFO, "Incoming File transfer: [" + offer.getNamespace() + ", "
+                + offer.getParent().getTransport().getNamespace() + ", "
+                + offer.getParent().getSecurity().getNamespace());
         for (IncomingFileOfferListener l : offerListeners) {
             l.onIncomingFileOffer(offer);
         }