Make Smack Java8's javac and javadoc ready

smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedConference.java

@@ -110,6 +110,7 @@ public class BookmarkedConference implements SharedBookmark {
         this.password = password;
     }
 
+    @Override
     public boolean equals(Object obj) {
         if(obj == null || !(obj instanceof BookmarkedConference)) {
             return false;
@@ -118,6 +119,11 @@ public class BookmarkedConference implements SharedBookmark {
         return conference.getJid().equalsIgnoreCase(jid);
     }
 
+    @Override
+    public int hashCode() {
+        return getJid().hashCode();
+    }
+
     protected void setShared(boolean isShared) {
         this.isShared = isShared;
     }

smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedURL.java

@@ -84,6 +84,7 @@ public class BookmarkedURL implements SharedBookmark {
         return isRss;
     }
 
+    @Override
     public boolean equals(Object obj) {
         if(!(obj instanceof BookmarkedURL)) {
             return false;
@@ -92,6 +93,11 @@ public class BookmarkedURL implements SharedBookmark {
         return url.getURL().equalsIgnoreCase(URL);
     }
 
+    @Override
+    public int hashCode() {
+        return getURL().hashCode();
+    }
+
     protected void setShared(boolean shared) {
         this.isShared = shared;
     }

smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/Form.java

@@ -27,11 +27,11 @@ import org.jivesoftware.smackx.xdata.packet.DataForm;
 /**
  * Represents a Form for gathering data. The form could be of the following types:
  * <ul>
- *  <li>form -> Indicates a form to fill out.</li>
- *  <li>submit -> The form is filled out, and this is the data that is being returned from 
+ *  <li>form &rarr; Indicates a form to fill out.</li>
+ *  <li>submit &rarr; The form is filled out, and this is the data that is being returned from 
  * the form.</li>
- *  <li>cancel -> The form was cancelled. Tell the asker that piece of information.</li>
- *  <li>result -> Data results being returned from a search, or some other query.</li>
+ *  <li>cancel &rarr; The form was cancelled. Tell the asker that piece of information.</li>
+ *  <li>result &rarr; Data results being returned from a search, or some other query.</li>
  * </ul>
  * 
  * Depending of the form's type different operations are available. For example, it's only possible
@@ -383,7 +383,7 @@ public class Form {
 
     /**
      * Returns the description of the data. It is similar to the title on a web page or an X 
-     * window.  You can put a <title/> on either a form to fill out, or a set of data results.
+     * window.  You can put a title on either a form to fill out, or a set of data results.
      * 
      * @return description of the data.
      */
@@ -423,7 +423,7 @@ public class Form {
 
     /**
      * Sets the description of the data. It is similar to the title on a web page or an X window.
-     * You can put a <title/> on either a form to fill out, or a set of data results.
+     * You can put a title on either a form to fill out, or a set of data results.
      * 
      * @param title description of the data.
      */

smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/FormField.java

@@ -165,9 +165,10 @@ public class FormField implements NamedElement {
     /**
      * Returns a description that provides extra clarification about the question. This information
      * could be presented to the user either in tool-tip, help button, or as a section of text
-     * before the question.<p>
-     * <p/>
+     * before the question.
+     * <p>
      * If the question is of type FIXED then the description should remain empty.
+     * </p>
      *
      * @return description that provides extra clarification about the question.
      */
@@ -255,9 +256,10 @@ public class FormField implements NamedElement {
     /**
      * Sets a description that provides extra clarification about the question. This information
      * could be presented to the user either in tool-tip, help button, or as a section of text
-     * before the question.<p>
-     * <p/>
+     * before the question.
+     * <p>
      * If the question is of type FIXED then the description should remain empty.
+     * </p>
      *
      * @param description provides extra clarification about the question.
      */

smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/XDataManager.java

@@ -51,7 +51,7 @@ public class XDataManager extends Manager {
     /**
      * Get the XDataManager for the given XMPP connection.
      *
-     * @param connection
+     * @param connection the XMPPConnection.
      * @return the XDataManager
      */
     public static synchronized XDataManager getInstanceFor(XMPPConnection connection) {