vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-12-14 06:51:08 +01:00
Code Issues Releases Wiki Activity

Add checkstyle rule for StringBuilder.append(char)

Browse source 
And replace all instances where String.Builder.append() is called with a
String of length one with append(char).

Also adds StringUtils.toStringBuilder(Collection, String).
This commit is contained in:
Florian Schmaus 2015-07-21 08:19:15 +02:00
parent 19ebcb814b
commit e0e4fd9b12
46 changed files with 159 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

14
smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
View file

@ -631,13 +631,13 @@ public final class EntityCapsManager extends Manager {
// followed by the '<' character.
for (DiscoverInfo.Identity identity : sortedIdentities) {
sb.append(identity.getCategory());
sb.append("/");
sb.append('/');
sb.append(identity.getType());
sb.append("/");
sb.append('/');
sb.append(identity.getLanguage() == null ? "" : identity.getLanguage());
sb.append("/");
sb.append('/');
sb.append(identity.getName() == null ? "" : identity.getName());
sb.append("<");
sb.append('<');
}
// 4. Sort the supported service discovery features.
@ -649,7 +649,7 @@ public final class EntityCapsManager extends Manager {
// character
for (String f : features) {
sb.append(f);
sb.append("<");
sb.append('<');
}
// only use the data form for calculation is it has a hidden FORM_TYPE
@ -690,7 +690,7 @@ public final class EntityCapsManager extends Manager {
// followed by the '<' character.
for (FormField f : fs) {
sb.append(f.getVariable());
sb.append("<");
sb.append('<');
formFieldValuesToCaps(f.getValues(), sb);
}
}
@ -719,7 +719,7 @@ public final class EntityCapsManager extends Manager {
}
for (String fv : fvs) {
sb.append(fv);
sb.append("<");
sb.append('<');
}
}