vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-12-18 08:51:08 +01:00
Code Issues Releases Wiki Activity

Add checkstyle rule for StringBuilder.append(char)

Browse source 
And replace all instances where String.Builder.append() is called with a
String of length one with append(char).

Also adds StringUtils.toStringBuilder(Collection, String).
This commit is contained in:
Florian Schmaus 2015-07-21 08:19:15 +02:00
parent 19ebcb814b
commit e0e4fd9b12
46 changed files with 159 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

4
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/Item.java
View file

@ -122,13 +122,13 @@ public class Item extends NodeExtension
{
builder.append(" id='");
builder.append(id);
builder.append("'");
builder.append('\'');
}
if (getNode() != null) {
builder.append(" node='");
builder.append(getNode());
builder.append("'");
builder.append('\'');
}
builder.append("/>");

2
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/ItemsExtension.java
View file

@ -183,7 +183,7 @@ public class ItemsExtension extends NodeExtension implements EmbeddedPacketExten
builder.append("</");
builder.append(getElementName());
builder.append(">");
builder.append('>');
return builder.toString();
}
}

6
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/PayloadItem.java
View file

@ -118,15 +118,15 @@ public class PayloadItem<E extends ExtensionElement> extends Item
{
builder.append(" id='");
builder.append(getId());
builder.append("'");
builder.append('\'');
}
if (getNode() != null) {
builder.append(" node='");
builder.append(getNode());
builder.append("'");
builder.append('\'');
}
builder.append(">");
builder.append('>');
builder.append(payload.toXML());
builder.append("</item>");

2
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/SubscribeExtension.java
View file

@ -52,7 +52,7 @@ public class SubscribeExtension extends NodeExtension
{
builder.append(" node='");
builder.append(getNode());
builder.append("'");
builder.append('\'');
}
builder.append(" jid='");
builder.append(getJid());

4
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/Subscription.java
View file

@ -153,11 +153,11 @@ public class Subscription extends NodeExtension
private static void appendAttribute(StringBuilder builder, String att, String value)
{
builder.append(" ");
builder.append(' ');
builder.append(att);
builder.append("='");
builder.append(value);
builder.append("'");
builder.append('\'');
}
}

6
smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/SubscriptionsExtension.java
View file

@ -81,9 +81,9 @@ public class SubscriptionsExtension extends NodeExtension
{
builder.append(" node='");
builder.append(getNode());
builder.append("'");
builder.append('\'');
}
builder.append(">");
builder.append('>');
for (Subscription item : items)
{
@ -92,7 +92,7 @@ public class SubscriptionsExtension extends NodeExtension
builder.append("</");
builder.append(getElementName());
builder.append(">");
builder.append('>');
return builder.toString();
}
}