vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2025-09-09 17:19:39 +02:00
Code Issues Releases Wiki Activity

Add checkstyle rule for StringBuilder.append(char)

Browse source 
And replace all instances where String.Builder.append() is called with a
String of length one with append(char).

Also adds StringUtils.toStringBuilder(Collection, String).
This commit is contained in:
Florian Schmaus 2015-07-21 08:19:15 +02:00
parent 19ebcb814b
commit e0e4fd9b12
46 changed files with 159 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

8
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/media/PayloadType.java
View file

@ -208,17 +208,17 @@ public class PayloadType {
public String toXML() {
StringBuilder buf = new StringBuilder();
buf.append("<").append(getElementName()).append(" ");
buf.append('<').append(getElementName()).append(' ');
// We covert here the payload type to XML
if (this.getId() != PayloadType.INVALID_PT) {
buf.append(" id=\"").append(this.getId()).append("\"");
buf.append(" id=\"").append(this.getId()).append('"');
}
if (this.getName() != null) {
buf.append(" name=\"").append(this.getName()).append("\"");
buf.append(" name=\"").append(this.getName()).append('"');
}
if (this.getChannels() != 0) {
buf.append(" channels=\"").append(this.getChannels()).append("\"");
buf.append(" channels=\"").append(this.getChannels()).append('"');
}
if (getChildAttributes() != null) {
buf.append(getChildAttributes());

12
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/RTPBridge.java
View file

@ -134,22 +134,22 @@ public class RTPBridge extends IQ {
StringBuilder str = new StringBuilder();
if (getSid() != null)
str.append(" sid='").append(getSid()).append("'");
str.append(" sid='").append(getSid()).append('\'');
if (getPass() != null)
str.append(" pass='").append(getPass()).append("'");
str.append(" pass='").append(getPass()).append('\'');
if (getPortA() != -1)
str.append(" porta='").append(getPortA()).append("'");
str.append(" porta='").append(getPortA()).append('\'');
if (getPortB() != -1)
str.append(" portb='").append(getPortB()).append("'");
str.append(" portb='").append(getPortB()).append('\'');
if (getHostA() != null)
str.append(" hosta='").append(getHostA()).append("'");
str.append(" hosta='").append(getHostA()).append('\'');
if (getHostB() != null)
str.append(" hostb='").append(getHostB()).append("'");
str.append(" hostb='").append(getHostB()).append('\'');
return str.toString();
}

10
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/Jingle.java
View file

@ -345,18 +345,18 @@ public class Jingle extends IQ {
*/
protected IQChildElementXmlStringBuilder getIQChildElementBuilder(IQChildElementXmlStringBuilder buf) {
if (getInitiator() != null) {
buf.append(" initiator=\"").append(getInitiator()).append("\"");
buf.append(" initiator=\"").append(getInitiator()).append('"');
}
if (getResponder() != null) {
buf.append(" responder=\"").append(getResponder()).append("\"");
buf.append(" responder=\"").append(getResponder()).append('"');
}
if (getAction() != null) {
buf.append(" action=\"").append(getAction().name()).append("\"");
buf.append(" action=\"").append(getAction().name()).append('"');
}
if (getSid() != null) {
buf.append(" sid=\"").append(getSid()).append("\"");
buf.append(" sid=\"").append(getSid()).append('"');
}
buf.append(">");
buf.append('>');
synchronized (contents) {
for (JingleContent content : contents) {

4
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleContent.java
View file

@ -162,7 +162,7 @@ public class JingleContent implements ExtensionElement {
synchronized (transports) {
buf.append("<").append(getElementName());
buf.append('<').append(getElementName());
buf.append(" creator='" + creator + "' name='" + name + "'>");
@ -175,7 +175,7 @@ public class JingleContent implements ExtensionElement {
for (JingleTransport transport : transports) {
buf.append(transport.toXML());
}
buf.append("</").append(getElementName()).append(">");
buf.append("</").append(getElementName()).append('>');
}
return buf.toString();
}

12
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleContentDescription.java
View file

@ -149,7 +149,7 @@ public abstract class JingleContentDescription implements ExtensionElement {
synchronized (payloads) {
if (payloads.size() > 0) {
buf.append("<").append(getElementName());
buf.append('<').append(getElementName());
buf.append(" xmlns=\"").append(getNamespace()).append("\" >");
Iterator<JinglePayloadType> pt = payloads.listIterator();
@ -157,7 +157,7 @@ public abstract class JingleContentDescription implements ExtensionElement {
JinglePayloadType pte = pt.next();
buf.append(pte.toXML());
}
buf.append("</").append(getElementName()).append(">");
buf.append("</").append(getElementName()).append('>');
}
}
@ -251,17 +251,17 @@ public abstract class JingleContentDescription implements ExtensionElement {
StringBuilder buf = new StringBuilder();
if (payload != null) {
buf.append("<").append(getElementName()).append(" ");
buf.append('<').append(getElementName()).append(' ');
// We covert here the payload type to XML
if (payload.getId() != PayloadType.INVALID_PT) {
buf.append(" id=\"").append(payload.getId()).append("\"");
buf.append(" id=\"").append(payload.getId()).append('"');
}
if (payload.getName() != null) {
buf.append(" name=\"").append(payload.getName()).append("\"");
buf.append(" name=\"").append(payload.getName()).append('"');
}
if (payload.getChannels() != 0) {
buf.append(" channels=\"").append(payload.getChannels()).append("\"");
buf.append(" channels=\"").append(payload.getChannels()).append('"');
}
if (getChildAttributes() != null) {
buf.append(getChildAttributes());

2
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleContentInfo.java
View file

@ -82,7 +82,7 @@ public class JingleContentInfo implements ExtensionElement {
public String toXML() {
StringBuilder buf = new StringBuilder();
buf.append("<").append(getElementName()).append(" xmlns=\"");
buf.append('<').append(getElementName()).append(" xmlns=\"");
buf.append(getNamespace()).append("\" ");
buf.append("/>");
return buf.toString();

4
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleDescription.java
View file

@ -156,7 +156,7 @@ public abstract class JingleDescription implements ExtensionElement {
synchronized (payloads) {
if (payloads.size() > 0) {
buf.append("<").append(getElementName());
buf.append('<').append(getElementName());
buf.append(" xmlns=\"").append(getNamespace()).append("\" >");
for (PayloadType payloadType : payloads) {
@ -164,7 +164,7 @@ public abstract class JingleDescription implements ExtensionElement {
buf.append(payloadType.toXML());
}
}
buf.append("</").append(getElementName()).append(">");
buf.append("</").append(getElementName()).append('>');
}
}

2
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleError.java
View file

@ -77,7 +77,7 @@ public class JingleError implements ExtensionElement {
StringBuilder buf = new StringBuilder();
if (message != null) {
buf.append("<error type=\"cancel\">");
buf.append("<").append(message).append(" xmlns=\"").append(NAMESPACE).append(
buf.append('<').append(message).append(" xmlns=\"").append(NAMESPACE).append(
"\"/>");
buf.append("</error>");
}

34
smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleTransport.java
View file

@ -151,19 +151,19 @@ public class JingleTransport implements ExtensionElement {
public String toXML() {
StringBuilder buf = new StringBuilder();
buf.append("<").append(getElementName()).append(" xmlns=\"");
buf.append('<').append(getElementName()).append(" xmlns=\"");
buf.append(getNamespace()).append("\" ");
synchronized (candidates) {
if (getCandidatesCount() > 0) {
buf.append(">");
buf.append('>');
Iterator<JingleTransportCandidate> iter = getCandidates();
while (iter.hasNext()) {
JingleTransportCandidate candidate = iter.next();
buf.append(candidate.toXML());
}
buf.append("</").append(getElementName()).append(">");
buf.append("</").append(getElementName()).append('>');
} else {
buf.append("/>");
}
@ -251,7 +251,7 @@ public class JingleTransport implements ExtensionElement {
String childElements = getChildElements();
if (transportCandidate != null && childElements != null) {
buf.append("<").append(getElementName()).append(" ");
buf.append('<').append(getElementName()).append(' ');
buf.append(childElements);
buf.append("/>");
}
@ -323,18 +323,18 @@ public class JingleTransport implements ExtensionElement {
ICECandidate tci = (ICECandidate) transportCandidate;
// We convert the transportElement candidate to XML here...
buf.append(" generation=\"").append(tci.getGeneration()).append("\"");
buf.append(" ip=\"").append(tci.getIp()).append("\"");
buf.append(" port=\"").append(tci.getPort()).append("\"");
buf.append(" network=\"").append(tci.getNetwork()).append("\"");
buf.append(" username=\"").append(tci.getUsername()).append("\"");
buf.append(" password=\"").append(tci.getPassword()).append("\"");
buf.append(" preference=\"").append(tci.getPreference()).append("\"");
buf.append(" type=\"").append(tci.getType()).append("\"");
buf.append(" generation=\"").append(tci.getGeneration()).append('"');
buf.append(" ip=\"").append(tci.getIp()).append('"');
buf.append(" port=\"").append(tci.getPort()).append('"');
buf.append(" network=\"").append(tci.getNetwork()).append('"');
buf.append(" username=\"").append(tci.getUsername()).append('"');
buf.append(" password=\"").append(tci.getPassword()).append('"');
buf.append(" preference=\"").append(tci.getPreference()).append('"');
buf.append(" type=\"").append(tci.getType()).append('"');
// Optional elements
if (transportCandidate.getName() != null) {
buf.append(" name=\"").append(tci.getName()).append("\"");
buf.append(" name=\"").append(tci.getName()).append('"');
}
}
@ -408,14 +408,14 @@ public class JingleTransport implements ExtensionElement {
if (transportCandidate != null && transportCandidate instanceof TransportCandidate.Fixed) {
TransportCandidate.Fixed tcf = (TransportCandidate.Fixed) transportCandidate;
buf.append(" generation=\"").append(tcf.getGeneration()).append("\"");
buf.append(" ip=\"").append(tcf.getIp()).append("\"");
buf.append(" port=\"").append(tcf.getPort()).append("\"");
buf.append(" generation=\"").append(tcf.getGeneration()).append('"');
buf.append(" ip=\"").append(tcf.getIp()).append('"');
buf.append(" port=\"").append(tcf.getPort()).append('"');
// Optional parameters
String name = tcf.getName();
if (name != null) {
buf.append(" name=\"").append(name).append("\"");
buf.append(" name=\"").append(name).append('"');
}
}
return buf.toString();