Improve SHIM API

- HeadersExtension.getHeaders() now returns a List instead of a Collection - Use XmlStringBuilder in Header and HeadersExtension toXML() - Add HeadersProviderTest - Use Smack formatting Also remove duplicate parsing code regarding SHIM from HOXT implementation.
2025-09-15 03:59:38 +02:00 · 2015-01-01 23:57:44 +01:00 · 2015-01-01 23:57:44 +01:00 · f2703bc195
commit f2703bc195
parent 06add179ec
7 changed files with 164 additions and 123 deletions
--- a/smack-extensions/src/test/java/org/jivesoftware/smackx/shim/provider/HeadersProviderTest.java
+++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/shim/provider/HeadersProviderTest.java
@ -0,0 +1,50 @@
+/**
+ *
+ * Copyright 2014 Florian Schmaus
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jivesoftware.smackx.shim.provider;
+
+import static org.junit.Assert.assertEquals;
+
+
+import org.jivesoftware.smack.packet.Message;
+import org.jivesoftware.smack.test.util.TestUtils;
+import org.jivesoftware.smack.util.PacketParserUtils;
+import org.jivesoftware.smackx.shim.packet.Header;
+import org.jivesoftware.smackx.shim.packet.HeadersExtension;
+import org.junit.Test;
+import org.xmlpull.v1.XmlPullParser;
+
+public class HeadersProviderTest {
+
+    @Test
+    public void headersInMessageTest() throws Exception {
+        // @formatter:off
+        final String messageStanza = 
+          "<message from='romeo@shakespeare.lit/orchard' to='juliet@capulet.com' type='chat'>" +
+            "<body>Wherefore are thou?!?</body>" + 
+            "<headers xmlns='http://jabber.org/protocol/shim'>" +
+             "<header name='Urgency'>high</header>" +
+            "</headers>" +
+          "</message>";
+        // @formatter:on
+        XmlPullParser parser = TestUtils.getMessageParser(messageStanza);
+        Message message = PacketParserUtils.parseMessage(parser);
+        HeadersExtension headers = HeadersExtension.from(message);
+        Header header = headers.getHeaders().get(0);
+        assertEquals("Urgency", header.getName());
+        assertEquals("high", header.getValue());
+    }
+}